-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Chlamydia support to test card #8389
Conversation
}, | ||
]; | ||
|
||
export default mockSupportedDiseaseTestPerformedChlamydia; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth a clean up PR to consolidate most of these mock files for the SupportedDiseaseTestPerformed entities
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Def worth a PR in my opinion. Maybe we can do it with the corresponding Chlamydia ticket since that should be the last STI?
@@ -71,6 +71,8 @@ import { | |||
baseStiAoeUpdateMock, | |||
device10Id, | |||
device10Name, | |||
chlamydiaDeviceId, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC we started using some of the device variables named with numbers like device7Name
when we were still transitioning from the era of supporting only COVID/Flu/Multiplex. At the time of adding HIV support, we wanted to verify the ordering of the 6 default devices plus the new HIV device as the 7th device. We've continued this number naming for the other STIs to maintain consistency, but at this point it seems a little cumbersome to continue so for this I opted to use a more descriptive name. These names could also be something to address in a clean up PR if we'd like
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I like the idea of a cleanup ticket as well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified on dev 5 -- great work on this!
FRONTEND PULL REQUEST
Related Issue
Changes Proposed
Additional Information
mockSupportedDiseaseTestPerformed[diseaseNameHere]
to mostly export from the same file instead of creating a new one for each new disease. Not terribly urgent thoughTesting
Big Organization
,Test Facility
Screenshots / Demos