Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chlamydia support to test card #8389

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Conversation

mpbrown
Copy link
Collaborator

@mpbrown mpbrown commented Jan 7, 2025

FRONTEND PULL REQUEST

Related Issue

Changes Proposed

  • Adds support for Chlamydia to the test card
  • Refactors some of the unit testing common among the generic STI AOE questions

Additional Information

  • Might be nice to refactor some of files with mockSupportedDiseaseTestPerformed[diseaseNameHere] to mostly export from the same file instead of creating a new one for each new disease. Not terribly urgent though
  • Definitely getting to the point with adding new STI support that we can start to identify other ways to make supported diseases more data-driven, particularly once we start implementing the designs for multi-condition test card

Testing

  • Deployed on dev5
  • Chlamydia device has been added to Big Organization, Test Facility

Screenshots / Demos

image

},
];

export default mockSupportedDiseaseTestPerformedChlamydia;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth a clean up PR to consolidate most of these mock files for the SupportedDiseaseTestPerformed entities

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Def worth a PR in my opinion. Maybe we can do it with the corresponding Chlamydia ticket since that should be the last STI?

@@ -71,6 +71,8 @@ import {
baseStiAoeUpdateMock,
device10Id,
device10Name,
chlamydiaDeviceId,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC we started using some of the device variables named with numbers like device7Name when we were still transitioning from the era of supporting only COVID/Flu/Multiplex. At the time of adding HIV support, we wanted to verify the ordering of the 6 default devices plus the new HIV device as the 7th device. We've continued this number naming for the other STIs to maintain consistency, but at this point it seems a little cumbersome to continue so for this I opted to use a more descriptive name. These names could also be something to address in a clean up PR if we'd like

@mpbrown mpbrown marked this pull request as ready for review January 7, 2025 17:28
Copy link

sonarqubecloud bot commented Jan 7, 2025

Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like the idea of a cleanup ticket as well!

Copy link
Collaborator

@bobbywells52 bobbywells52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on dev 5 -- great work on this!

@mpbrown mpbrown added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit 0f28f34 Jan 10, 2025
37 checks passed
@mpbrown mpbrown deleted the mike/7435-chlamydia-test-card branch January 10, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test card supports Chlamydia test results
3 participants