Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sendOrgAdminEmailCsv flaky backend test #8390

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Fix sendOrgAdminEmailCsv flaky backend test #8390

merged 1 commit into from
Jan 11, 2025

Conversation

emyl3
Copy link
Collaborator

@emyl3 emyl3 commented Jan 7, 2025 •
edited
Loading

BACKEND PULL REQUEST

Related Issue

Changes Proposed

  • try using argumentCaptor instead of argumentMatcher
  • break out the tests to assert on one test case to try and avoid the TooManyActualInvocations exception

Additional Information

  • removed one test that was redundant
  • reran the backend tests in CI 5 times that all passed

Testing

  • backend tests should pass (hopefully) without it failing randomly on any of the sendOrgAdminEmailCSVAsync tests

@emyl3 emyl3 force-pushed the elisa/backend-flaky-test branch 2 times, most recently from bc875a5 to 1af1b78 Compare January 9, 2025 19:45
@emyl3 emyl3 force-pushed the elisa/backend-flaky-test branch from 1af1b78 to 5569f80 Compare January 9, 2025 19:53
emyl3
emyl3 commented Jan 9, 2025
View reviewed changes
backend/src/test/java/gov/cdc/usds/simplereport/service/OrganizationServiceTest.java

String njExternalId = "d6b3951b-6698-4ee7-9d63-aaadee85bac0";
Copy link
Collaborator Author

@emyl3 emyl3 Jan 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ removed this test lines 609-614 since it was redundant with the previous one

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@emyl3 emyl3 marked this pull request as ready for review January 9, 2025 22:04
mpbrown
mpbrown approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@mpbrown mpbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for looking into this flaky test!

mehansen
mehansen approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@mehansen mehansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@emyl3 emyl3 added this pull request to the merge queue Jan 11, 2025
Merged via the queue into main with commit f67eb78 Jan 11, 2025
33 checks passed
@emyl3 emyl3 deleted the elisa/backend-flaky-test branch January 11, 2025 00:32
@emyl3 emyl3 mentioned this pull request Jan 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpbrown mpbrown mpbrown approved these changes

@mehansen mehansen mehansen approved these changes

@DavidMcClatchey DavidMcClatchey Awaiting requested review from DavidMcClatchey

@bobbywells52 bobbywells52 Awaiting requested review from bobbywells52

@arinkulshi-skylight arinkulshi-skylight Awaiting requested review from arinkulshi-skylight

@DanielSass DanielSass Awaiting requested review from DanielSass

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emyl3 @mehansen @mpbrown