Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chlamydia Results Page #8399

Merged
merged 10 commits into from
Jan 17, 2025
Merged

Chlamydia Results Page #8399

merged 10 commits into from
Jan 17, 2025
+104 −1

Conversation

bobbywells52
Copy link
Collaborator

@bobbywells52 bobbywells52 commented Jan 14, 2025 •
edited
Loading

FRONTEND PULL REQUEST

Related Issue

Changes Proposed

  • Add English and Spanish copy for a Chlamydia result and logic to display said copy to the user pending a positive result

Additional Information

  • decisions that were made
  • notice of future work that needs to be done

Testing

  • Live for testing in dev1 with send grid enabled
  • Ensure that for a positive chlamydia result that the pxp flow works as excepted and can be viewed in the admin results view as well.

Screenshots / Demos

Screenshot 2025-01-16 at 1 53 54 PM Screenshot 2025-01-16 at 1 54 12 PM Screenshot 2025-01-16 at 1 55 18 PM Screenshot 2025-01-16 at 1 55 29 PM

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bobbywells52 bobbywells52 marked this pull request as ready for review January 16, 2025 21:00
@bobbywells52 bobbywells52 changed the title Bobby/7439 Chlamydia Results Page Jan 16, 2025
mpbrown
mpbrown approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@mpbrown mpbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

emyl3
emyl3 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, Bobby! 🎉

@bobbywells52 bobbywells52 added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 74caf63 Jan 17, 2025
43 checks passed
@bobbywells52 bobbywells52 deleted the bobby/7439 branch January 17, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpbrown mpbrown mpbrown approved these changes

@emyl3 emyl3 emyl3 approved these changes

@mehansen mehansen Awaiting requested review from mehansen

@DanielSass DanielSass Awaiting requested review from DanielSass

@DavidMcClatchey DavidMcClatchey Awaiting requested review from DavidMcClatchey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Results page supports Chlamydia test results
3 participants
@bobbywells52 @emyl3 @mpbrown