Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 0.0.5 release #147

Merged
merged 6 commits into from
Apr 23, 2021
Merged

Version 0.0.5 release #147

merged 6 commits into from
Apr 23, 2021

Conversation

sfarrens
Copy link
Contributor

@sfarrens sfarrens commented Apr 14, 2021 •
edited
Loading

Summary

  • Set fixed versions for all package dependencies to have a more stable version of PySAP
  • Dropped Circle and Travis CI
  • Set up CI using GitHub actions
  • Added example tests to CI build
  • Added PySAP Dockerfile with Jupyter notebook interface
  • Updated conda environment.yml to facilitate local installation
  • Updated .readthedocs.yml to use conda environment
  • Added new MRI examples

ModOpt and Plug-In Versions

  • ModOpt v1.5.1
  • PySAP-Astro v0.0.1
  • PySAP-MRI v0.3.0

PRs Included

sfarrens added 2 commits April 14, 2021 16:40
@sfarrens
add initial CI setup to develop branch to trigger tests
9fc44c1
@sfarrens
Release preparation (#146)
e988e53 
* set fixed package versions

* fixed discrepancy

* test with v3.4.0 of matplotlib

* lowered packages versions for python 3.6 support

* fixed nibabel version

* test github actions

* test running examples

* exclude example tests from nosetests

* fixed script name

* install pysap before running examples
@sfarrens sfarrens self-assigned this Apr 14, 2021
@sfarrens
PySAP installation updates (#150)
961cdfd 
* updated conda env

* updated environment

* updated conda env

* removed tensorflow from env

* added pynfft to env

* added Dockerfile

* removed test lines from Dockerfile
@sfarrens sfarrens linked an issue Apr 22, 2021 that may be closed by this pull request
CI: check properly Python dependencies. #12
Closed
philouc
philouc reviewed Apr 22, 2021
View reviewed changes
Copy link
Contributor

@philouc philouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apt-get install -> apt install

@sfarrens
Copy link
Contributor Author

apt-get install -> apt install

@philouc are you referring to the Dockerfile?

@philouc
Copy link
Contributor

philouc commented Apr 22, 2021

apt-get install -> apt install

@philouc are you referring to the Dockerfile?

Yes (Lines 12 to 19) as far as I know!

@sfarrens
Copy link
Contributor Author

sfarrens commented Apr 22, 2021 •
edited
Loading

apt-getinstall -> apt install

@philouc are you referring to the Dockerfile?

Yes (Lines 12 to 19) as far as I know!

@philouc as far as I can see apt-get is the preference for use inside scripts and is what is suggested for Dockerfiles. According to this apt is preferred in the command line as it is more verbose.

sfarrens and others added 3 commits April 22, 2021 19:51
@sfarrens
Plug-in versions (#149)
1916115 
* set plug-in and modopt versions for next release

* updated pysap-mri version
@chaithyagr @sfarrens
Added new examples (#152)
51f20a2 
Co-authored-by: chaithyagr <[email protected]>
Co-authored-by: Samuel Farrens <[email protected]>
@sfarrens
Release clean up (#151)
ac4f96e 
* updated readme

* fixed typos

* updated docker instructions

* updated readthedocs to use conda env
@sfarrens sfarrens requested a review from AGrigis April 23, 2021 13:54
@sfarrens sfarrens marked this pull request as ready for review April 23, 2021 13:54
@sfarrens sfarrens merged commit 702e843 into master Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philouc philouc philouc left review comments

@AGrigis AGrigis Awaiting requested review from AGrigis

Assignees

@sfarrens sfarrens

Labels
Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: check properly Python dependencies.
3 participants
@sfarrens @philouc @chaithyagr