overridden: frontsite: Override Document Item table to show shelf link #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpsherva
reviewed
Apr 8, 2024
ui/src/overridden/frontsite/Document/DocumentDetails/DocumentItemBody.js
Outdated
Show resolved
Hide resolved
kpsherva
reviewed
Apr 8, 2024
ui/src/overridden/frontsite/Document/DocumentDetails/DocumentItemBody.js
Outdated
Show resolved
Hide resolved
sakshamarora1
force-pushed
the
feature/shelf_maps_link
branch
from
35a3d83 to
37850a4
Compare
kpsherva
reviewed
Apr 19, 2024
| { "type": "shelf_number", "key": "123", "text": "SHELF 123" }, | ||
| { "type": "shelf_number", "key": "124", "text": "SHELF 124" }, | ||
| { "type": "shelf_number", "key": "125", "text": "SHELF 125" }, | ||
| { "type": "shelf_number", "key": "126", "text": "SHELF 126" } |
There was a problem hiding this comment.
just to make sure: is it like we discussed, not a required field?
kpsherva
reviewed
Apr 19, 2024
| <Embed | ||
| active | ||
| url={shelfLink(metadata.shelf, true)} | ||
| style={{ |
There was a problem hiding this comment.
Could you move the styling to site.overridable? Inline styling is generally among bad practices
kpsherva
reviewed
Apr 19, 2024
| <Embed | ||
| active | ||
| url={shelfLink(shelfNumber, true)} | ||
| style={{ |
kpsherva
reviewed
Apr 19, 2024
| color="blue" | ||
| fluid | ||
| > | ||
| Open MapCERN |
There was a problem hiding this comment.
I think the demo outcome was Find it on shelf
kpsherva
reviewed
Apr 19, 2024
| return invenioConfig.ITEMS.canCirculateStatuses.includes(item.status); | ||
| } | ||
|
|
||
| function isItemForReference(item) { |
There was a problem hiding this comment.
could you make sure (check with Salome or Lydia) the for reference items should also have map displayed?
sakshamarora1
force-pushed
the
feature/shelf_maps_link
branch
from
7f1a32c to
2368d87
Compare
kpsherva
force-pushed
the
feature/shelf_maps_link
branch
from
17b2594 to
6fcdbad
Compare
kpsherva
force-pushed
the
feature/shelf_maps_link
branch
from
fd4a3e1 to
3cdce38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #834