Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

permissions: move self-checkout to invenio-app-ils #918

Merged
merged 1 commit into from
Oct 28, 2024
Merged

permissions: move self-checkout to invenio-app-ils #918

merged 1 commit into from
Oct 28, 2024

Conversation

ntarocco
Copy link
Contributor

@ntarocco ntarocco commented Oct 16, 2024 •
edited
Loading

ntarocco
ntarocco commented Oct 16, 2024
View reviewed changes
cds_ils/patrons/permissions.py
@@ -38,6 +37,4 @@ def views_permissions_factory(action):
return retrieve_patron_loans_permission()
elif action == "document-importer":
return document_importer_permission()
elif action == "circulation-loan-checkout":
return authenticated_user_permission()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to invenio-app-ils, with the check for ILS_SELF_CHECKOUT_ENABLED.

@ntarocco
Copy link
Contributor Author

The test should pass after the release of invenio-app-ils.

@ntarocco ntarocco merged commit 166a407 into master Oct 28, 2024
2 checks passed
@ntarocco ntarocco deleted the fix/self-checkout branch October 28, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sakshamarora1 sakshamarora1 sakshamarora1 approved these changes

@kpsherva kpsherva kpsherva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ntarocco @kpsherva @sakshamarora1