global: upgrade to 12.0.0b3.dev7 #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpsherva
reviewed
Apr 2, 2024
| @@ -81,3 +81,6 @@ celerybeat-schedule.db | |||
| # node modules | |||
| **/*/node_modules | |||
| node_modules | |||
|
|
|||
| # local tmp folder | |||
| tmp | |||
There was a problem hiding this comment.
not needed I added so I can keep track of some local files without committing them. I can remove them if you think it is confusing.
kpsherva
reviewed
Apr 2, 2024
site/setup.cfg
Outdated
| @@ -20,7 +20,7 @@ tests = | |||
| [options.entry_points] | |||
| flask.commands = | |||
| cds-admin = cds_rdm.cli:cds_admin | |||
| migration = cds_rdm.migration.cli:migration | |||
| # migration = cds_rdm.migration.cli:migration | |||
There was a problem hiding this comment.
nit: maybe it is better to group the commented out entrypoints together
kpsherva
reviewed
Apr 2, 2024
Pipfile
Outdated
| [pipenv] | ||
| allow_prereleases = false | ||
| allow_prereleases = true |
There was a problem hiding this comment.
yes for the dev release of invenio-app-rdm (+ invenio-rdm-migrator if we go with it).
ntarocco
approved these changes
Apr 2, 2024
Pipfile
Outdated
| [pipenv] | ||
| allow_prereleases = false | ||
| allow_prereleases = true |
invenio.cfg
Outdated
|
|
||
| # CDS Administration panel | ||
| # ======================== | ||
| USERS_RESOURCES_ADMINISTRATION_ENABLED = True |
There was a problem hiding this comment.
I think we really need to change invenio-users-resources and now enable it by default. Feel free to add a commit there
zzacharo
force-pushed
the
cds-rdm-ugrade
branch
2 times, most recently
from
6c0af38 to
aad29b3
Compare
zzacharo
changed the title
zzacharo
force-pushed
the
cds-rdm-ugrade
branch
4 times, most recently
from
e52ea2a to
76c9b70
Compare
ntarocco
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.