Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installing to a custom path #1

Closed
andrei-pavel opened this issue Sep 7, 2021 · 6 comments
Closed

installing to a custom path #1

andrei-pavel opened this issue Sep 7, 2021 · 6 comments
Labels
question Further information is requested

Comments

@andrei-pavel
Copy link
Contributor

Hello!

When installing sysrepo from sources, I am able to have libyang installed in a custom path by providing this command:

cmake -DLIBYANG_INCLUDE_DIR="/opt/libyang/include" -DLIBYANG_LIBRARY="/opt/libyang/lib/libyang.so"

This doesn't seem to be an option for libyang-cpp and libsysrepo-cpp. Could this be done?

My goal is to have all four repos installed in custom paths, so that they can be easily uninstalled without make uninstall which requires the user to have access to the sources.

Thanks!

@syyyr syyyr added the question Further information is requested label Sep 7, 2021
@syyyr
Copy link
Contributor

syyyr commented Sep 7, 2021

Hi,

it is possible to install libyang-cpp in a custom path by using the CMAKE_INSTALL_PREFIX variable. So, in your case, your cmake invocation would look something like this:

cmake -DCMAKE_INSTALL_PREFIX="/opt/libyang-cpp"

Let me know, if you have any more questions.

@andrei-pavel
Copy link
Contributor Author

-- Checking for modules 'libyang>=2.0.7;libyang'
--   Package 'libyang', required by 'virtual:world', not found
--   Package 'libyang', required by 'virtual:world', not found
CMake Error at /usr/share/cmake-3.21/Modules/FindPkgConfig.cmake:562 (message):
A required package was not found

It can't find /opt/libyang.

@syyyr
Copy link
Contributor

syyyr commented Sep 7, 2021

This is more of a cmake problem, then libyang/libyang-cpp problem, but if you installed libyang in a non-standard location, you need to tell cmake where libyang is. If you installed libyang with this command:

cmake -DLIBYANG_INCLUDE_DIR="/opt/libyang/include" -DLIBYANG_LIBRARY="/opt/libyang/lib/libyang.so"

then it should be enough to set the CMAKE_PREFIX_PATH variable to /opt/libyang when invoking cmake for libyang-cpp. We are using pkg-config to find libyang.

@andrei-pavel
Copy link
Contributor Author

That's the problem I'm facing. Those commands don't work. Taking inspiration from sysrepo, I think libyang-cpp needs these lines in CMakeLists.txt:

target_link_libraries(libyang-cpp ${LIBYANG_LIBRARIES})
include_directories(${LIBYANG_INCLUDE_DIRS})

@syyyr
Copy link
Contributor

syyyr commented Sep 7, 2021

libyang is linked to libyang-cpp through pkg-config. That means that as long as pkg-config knows where libyang is, then libyang-cpp will also know where it is. So it all comes down to whether it does know, or does not. One way to debug pkg-config is to use this command:

pkg-config libyang --libs

If this gives an error, you need to tell pkg-config where libyang is. There are two options.

  1. point the PKG_CONFIG_PATH enviromental variable to your libyang prefix when invoking cmake
  2. if your cmake is new enough (version 3.1), set the CMAKE_PREFIX_PATH to the install prefix of libyang and cmake should append this path to PKG_CONFIG_PATH automatically.

@andrei-pavel
Copy link
Contributor Author

Thanks much!

jktjkt pushed a commit that referenced this issue Sep 6, 2024
There is ODR violation in libyang tests reported by ASan which breaks
our CI builds. This commit temporarily (until this gets solved in
upstream) pins the libyang version to 3.0.18 which builds just fine.

The log from ASan:

  52/60 Test #31: utest_plugins .....................***Failed    1.22 sec
  [==========] tests: Running 4 test(s).
  [ RUN      ] test_add_invalid
  [       OK ] test_add_invalid
  [ RUN      ] test_add_simple
  =================================================================
  ==2826==ERROR: AddressSanitizer: odr-violation (0x7f6d170dcb40):
    [1] size=24 'ly_version_so' /home/ci/src/cesnet-gerrit-public/github/CESNET/libyang/src/ly_common.c:43
    [2] size=24 'ly_version_so' /home/ci/src/cesnet-gerrit-public/github/CESNET/libyang/src/ly_common.c:43
  These globals were registered at these points:
    [1]:
      #0 0x437ffa in __asan_register_globals (/home/ci/build/github/CESNET/libyang/tests/utest_plugins+0x437ffa) (BuildId: e79d14f37e59b6533b66d19363b25fea9e324edb)
      #1 0x7f6d16691b9e in asan.module_ctor ly_common.c
      #2 0x7f6d1aad7236 in call_init /usr/src/debug/glibc-2.37-18.fc38.x86_64/elf/dl-init.c:74:3
      #3 0x7f6d1aad7236 in call_init /usr/src/debug/glibc-2.37-18.fc38.x86_64/elf/dl-init.c:26:1
      #4 0x7f6d1aad732c in _dl_init /usr/src/debug/glibc-2.37-18.fc38.x86_64/elf/dl-init.c:121:5
      #5 0x7f6d1aad35c1 in _dl_catch_exception /usr/src/debug/glibc-2.37-18.fc38.x86_64/elf/dl-catch.c:211:7
      #6 0x7f6d1aaddeeb in dl_open_worker /usr/src/debug/glibc-2.37-18.fc38.x86_64/elf/dl-open.c:827:5
      #7 0x7f6d1aad3522 in _dl_catch_exception /usr/src/debug/glibc-2.37-18.fc38.x86_64/elf/dl-catch.c:237:8
      #8 0x7f6d1aade2e3 in _dl_open /usr/src/debug/glibc-2.37-18.fc38.x86_64/elf/dl-open.c:903:17
      #9 0x7f6d1a7b5713 in dlopen_doit /usr/src/debug/glibc-2.37-18.fc38.x86_64/dlfcn/dlopen.c:56:15
      #10 0x7f6d1aad3522 in _dl_catch_exception /usr/src/debug/glibc-2.37-18.fc38.x86_64/elf/dl-catch.c:237:8
      #11 0x7f6d1aad3678 in _dl_catch_error /usr/src/debug/glibc-2.37-18.fc38.x86_64/elf/dl-catch.c:256:19
      #12 0x7f6d1a7b51f2 in _dlerror_run /usr/src/debug/glibc-2.37-18.fc38.x86_64/dlfcn/dlerror.c:138:17
      #13 0x7f6d1a7b57ce  /usr/src/debug/glibc-2.37-18.fc38.x86_64/dlfcn/dlopen.c:71:10
      #14 0x7f6d1a7b57ce in dlopen@@GLIBC_2.34 /usr/src/debug/glibc-2.37-18.fc38.x86_64/dlfcn/dlopen.c:81:12
      #15 0x485f82 in dlopen (/home/ci/build/github/CESNET/libyang/tests/utest_plugins+0x485f82) (BuildId: e79d14f37e59b6533b66d19363b25fea9e324edb)
      #16 0xcb5ee3 in plugins_load_module /home/ci/src/cesnet-gerrit-public/github/CESNET/libyang/src/plugins.c:378:17
      #17 0xcb5e67 in lyplg_add /home/ci/src/cesnet-gerrit-public/github/CESNET/libyang/src/plugins.c:589:11
      #18 0xea2a60 in test_add_simple /home/ci/src/cesnet-gerrit-public/github/CESNET/libyang/tests/utests/basic/test_plugins.c:50:5
      #19 0x7f6d1aac218f  (/lib64/libcmocka.so.0+0x618f) (BuildId: 785844a0941c0bde763740a981d056f60aa9c7b7)
      #20 0x7f6d1aac2904 in _cmocka_run_group_tests (/lib64/libcmocka.so.0+0x6904) (BuildId: 785844a0941c0bde763740a981d056f60aa9c7b7)
      #21 0xea21a2 in main /home/ci/src/cesnet-gerrit-public/github/CESNET/libyang/tests/utests/basic/test_plugins.c:152:12

Change-Id: Id8a4771296d2e85de2ec29fbd17046d280d2eda2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants