Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect link to https://github.com/norlab-ulaval/libpointmatcher/blob/master/doc/CompilationWindows.md #8323

Closed
albert-github opened this issue Jul 1, 2024 · 2 comments

Comments

@albert-github
Copy link
Contributor

In the documentation output file doc_output/Manual/thirdparty.html we get (when running a link checker):

List of broken links and other issues:
https://github.com/ethz-asl/libpointmatcher/blob/master/doc/CompilationWindows.md
-> https://github.com/norlab-ulaval/libpointmatcher/blob/master/doc/CompilationWindows.md
  Line: 248
  Code: 301 -> 404 Not Found
 To do: The link is broken. Double-check that you have not made any typo,
        or mistake in copy-pasting. If the link points to a resource that
        no longer exists, you may want to remove or fix the link.

The redirect is not a problem, but the destination file CompilationWindows.md does not exist anymore:

Commit: 67032b76791135d48126501a9552197fde41ebfb [67032b7]
Parents: c865d15d92
Author: boxanm <[email protected]>
Date: Sunday, May 5, 2024 5:59:31 PM
Committer: boxanm
Commit Date: Sunday, May 5, 2024 5:59:36 PM
Move the compilation guides into a single file

a.o. the file CompilationWindows.md has been moved into Compilation.md.

@afabri
Copy link
Member

afabri commented Aug 6, 2024

@albert-github I hope I correctly understood that the merge of PR #8324 fixes the issue.

@afabri afabri closed this as completed Aug 6, 2024
@albert-github
Copy link
Contributor Author

@afabri that was the intention of the PR (looks like I forgot to add here in #8323 my usual text: I've just pushed a proposed patch, pull request #8324)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants