Using c++17 standard library #7526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use Mesh_3::internal::get_index std::dynamic_point_cast std::get_if
sloriot
added
Modern C++ (C++11 and later)
depends on another PR
…lope changes in arrangement based packages
sloriot
force-pushed
the
CGAL-using_c++17_stl
branch
from
318315a to
76f16d7
Compare
sloriot
force-pushed
the
CGAL-using_c++17_stl
branch
from
86a13fa to
e759fb4
Compare
changes in Arrangement_on_surface_2/include/CGAL/Arr_polycurve_traits_2.h should be undo
restore changes in Arr_polycurve_traits_2
`error C2338: Sorry: std::any doesn't support over-aligned types at this time.`
|
Successfully tested in CGAL-6.0-Ic-43 |
This comment was marked as off-topic.
This comment was marked as off-topic.
sloriot
force-pushed
the
CGAL-using_c++17_stl
branch
from
21ee608 to
d6c04e3
Compare
MaelRL
added a commit
to MaelRL/cgal
that referenced
this pull request
Jan 16, 2025
sloriot
added a commit
that referenced
this pull request
Jan 20, 2025
## Summary of Changes Some occurrences that slipped through. See #7526 ## Release Management * Affected package(s): `Tetrahedral_remeshing`, `Triangulation_3` * Issue(s) solved (if any): - * Feature/Small Feature (if any): - * License and copyright ownership: no change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use std::shared_ptr, std::optional, std::variant, ...
These are important changes since they appear in the CGAL API and thus are breaking changes.
includes #7416