Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize documentation of Face_filtered_graph #7595

Merged
merged 6 commits into from
Sep 7, 2023

Conversation

MaelRL
Copy link
Member

@MaelRL MaelRL commented Jul 12, 2023

Summary of Changes

The current doc says that the selection patch IDs need to be of type faces_size_type, but this requirement doesn't exist in the code.

The doc is generalized, and the actual requirement (the type must be Hashable) is added.

TODO:

  • Add a few words in the description of the FFG class

Release Management

@sloriot

This comment was marked as resolved.

@sloriot sloriot added Tests failing Batch_1 First Batch of PRs under testing and removed Under Testing labels Jul 13, 2023
@MaelRL
Copy link
Member Author

MaelRL commented Jul 17, 2023

@janetournois What was the use case where you needed a FFG with Booleans? We could add an example as there are currently 3 examples with FFG, but they are all using a std::size_t value type.

@MaelRL MaelRL added the TODO label Jul 17, 2023
@sloriot
Copy link
Member

sloriot commented Jul 19, 2023

Successfully tested in CGAL-6.0-Ic-24.

@janetournois
Copy link
Member

@janetournois What was the use case where you needed a FFG with Booleans? We could add an example as there are currently 3 examples with FFG, but they are all using a std::size_t value type.

It was for isotropic remeshing of a selection of faces. @ipadjen do you remember where exactly you needed that?

@ipadjen
Copy link
Member

ipadjen commented Aug 3, 2023

It was one of ideas to use it for curvature calculation of a mesh selection. Currently we have the face descriptor for ffg: https://github.com/janetournois/cgal/blob/2bb1e97847204d2ce5acc1025487201f81d7a4dc/Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/internal/Isotropic_remeshing/Adaptive_sizing_field.h#L65-L72

@MaelRL MaelRL removed the TODO label Sep 5, 2023
@sloriot sloriot added rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' and removed Ready to be tested Batch_1 First Batch of PRs under testing labels Sep 6, 2023
@lrineau lrineau self-assigned this Sep 7, 2023
@lrineau lrineau merged commit cdd4b2c into CGAL:master Sep 7, 2023
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BGL - add Face_filtered_graph constructor from boolean property map
6 participants