-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize documentation of Face_filtered_graph #7595
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
@janetournois What was the use case where you needed a FFG with Booleans? We could add an example as there are currently 3 examples with FFG, but they are all using a std::size_t value type. |
Successfully tested in CGAL-6.0-Ic-24. |
It was for isotropic remeshing of a selection of faces. @ipadjen do you remember where exactly you needed that? |
It was one of ideas to use it for curvature calculation of a mesh selection. Currently we have the face descriptor for ffg: https://github.com/janetournois/cgal/blob/2bb1e97847204d2ce5acc1025487201f81d7a4dc/Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/internal/Isotropic_remeshing/Adaptive_sizing_field.h#L65-L72 |
Summary of Changes
The current doc says that the selection patch IDs need to be of type faces_size_type, but this requirement doesn't exist in the code.
The doc is generalized, and the actual requirement (the type must be
Hashable
) is added.TODO:
Release Management
BGL
,Stream_support
Face_filtered_graph
constructor from boolean property map #7570