Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for vertex/cell classes of SMDS_3 and Tetrahedral_remeshing #7610

Merged
merged 12 commits into from
Sep 13, 2023
Merged

Fixes for vertex/cell classes of SMDS_3 and Tetrahedral_remeshing #7610

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e11bbab
De-compactify Simplicial_mesh_cell_base_3
MaelRL Jul 19, 2023
4e824ed
Improve doc of Simplicial_vertex_base_3
MaelRL Jul 19, 2023
50fa1ee
Various fixes for Remeshing_cell_base_3:
MaelRL Jul 19, 2023
c0d0c0d
Fix API of Remeshing_vertex_base_3:
MaelRL Jul 19, 2023
ce9fa95
Fixes for the doc of tetrahedral remeshing
MaelRL Jul 19, 2023
796baca
Misc minor cleaning
MaelRL Jul 19, 2023
3ad1825
Fix not being able to Rebind multiple time SMDS_3 / Tet Remesh Vb/Cb
MaelRL Jul 21, 2023
a935682
(Re-)introduce Compact_simplicial_mesh_cell_base_3
MaelRL Jul 24, 2023
cdb0a1c
Merge remote-tracking branch 'cgal/master' into SMDS_3-Fix_stack-GF
MaelRL Sep 5, 2023
e2832df
Merge remote-tracking branch 'cgal/master' into SMDS_3-Fix_stack-GF
MaelRL Sep 7, 2023
3ef293b
Update to new cgalModels
MaelRL Sep 8, 2023
cb68fdf
Add breaking changes
MaelRL Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions SMDS_3/doc/SMDS_3/Concepts/SimplicialMeshCellBase_3.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,12 @@

The concept `SimplicialMeshCellBase_3` describes the requirements
for the `TriangulationDataStructure_3::Cell` type of the triangulation
used in the 3D simplicial mesh data structure. The type `SimplicialMeshCellBase_3`
refines the concept `TriangulationCellBase_3`
and must be copy constructible.
The concept `SimplicialMeshCellBase_3`
includes a way to store and retrieve
if a given cell of the triangulation is inside a subdomain or not,
and which subdomain it belongs to
in case of a multi-domain.
used in a 3D simplicial mesh data structure.

The type `SimplicialMeshCellBase_3` refines the concept `TriangulationCellBase_3`
and must be copy constructible. The concept `SimplicialMeshCellBase_3` includes a way to store and
retrieve if a given cell of the triangulation is inside a subdomain or not, and which subdomain it
belongs to in case of a multi-domain.

Moreover, this concept adds four markers per cell to mark the facets
of the triangulation that are surface facets.
Expand Down
2 changes: 1 addition & 1 deletion SMDS_3/doc/SMDS_3/Concepts/SimplicialMeshVertexBase_3.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

The concept `SimplicialMeshVertexBase_3` describes the requirements
for the `Vertex` type of the triangulation
used in the 3D simplicial mesh data structure. The type `SimplicialMeshVertexBase_3`
used in a 3D simplicial mesh data structure. The type `SimplicialMeshVertexBase_3`
refines the concept `TriangulationVertexBase_3`.
It provides additional members to store and retrieve
information about the location of the vertex with respect
Expand Down
2 changes: 1 addition & 1 deletion SMDS_3/examples/SMDS_3/c3t3_example.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ using Surface_patch_index = unsigned char;
using Curve_index = char;
using Corner_index = short;

using Cb = CGAL::Simplicial_mesh_cell_base_3<Subdomain_index, Surface_patch_index>;
using Cb = CGAL::Simplicial_mesh_cell_base_3<K, Subdomain_index, Surface_patch_index>;
using Vb = CGAL::Simplicial_mesh_vertex_base_3<K, Subdomain_index, Surface_patch_index,
Curve_index, Corner_index>;

Expand Down
2 changes: 1 addition & 1 deletion SMDS_3/include/CGAL/Mesh_complex_3_in_triangulation_3.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ namespace CGAL {
vertex and cell base class are models of the concepts
`SimplicialMeshVertexBase_3` and `SimplicialMeshCellBase_3`, respectively.

\tparam CornerIndex Type of indices for corners (i.e.\f$ 0\f$--dimensional features)
\tparam CornerIndex Type of indices for corners (i.e.\f$ 0\f$--dimensional features)
of the discretized geometric domain.
It must be a model of `CopyConstructible`, `Assignable`, `DefaultConstructible` and
`LessThanComparable`.
Expand Down
Loading