Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autorefine for triangle soup #7614

Merged
merged 105 commits into from
Dec 26, 2023
Merged

Add autorefine for triangle soup #7614

merged 105 commits into from
Dec 26, 2023

Conversation

sloriot
Copy link
Member

@sloriot sloriot commented Jul 21, 2023 •
edited
Loading

Summary of Changes

Add the function PMP::autorefine_triangle_soup() (and autorefine()) to resolve self-intersection of triangles.

This PR also improves the 3D triangle intersection computation when the triangles are coplanar. The same tricks could be backported in 2D if needed.

Release Management

  • Affected package(s): PMP
  • Feature/Small Feature (if any): here Pre-approved on 2023/12/12
  • Link to compiled documentation (obligatory for small feature) here
  • License and copyright ownership: GF

TODO:

  • small feature
  • CHANGED.md
  • tests
  • remove useless debug code
  • remove code branches hidden with the preprocessor if they are not needed anymore
  • address remaining TODO in the code (or decide to drop them)
  • add an option to remove duplicated triangles (coplanar patches opti...) Left for later if someone asks for it

sloriot added 30 commits April 6, 2023 17:54
@sloriot
add "brute-force" version of autorefine()
a1ff847
@sloriot
add option to directly dump the soup
b0edd90
@sloriot
skip degenerate faces
47ac016
@sloriot
add another example with soup as input
6df9926
@sloriot
add debug
e1414de
@sloriot
use all vertices in the check
85368c4
@sloriot
triangulate input faces
944475f
@sloriot
faster implementation + fix intersection segments + check
2b77fcd
@sloriot
fix condition
d92d37c
@sloriot
disable CDT+ that is slower and add debug
34e8d7e
@sloriot
update doc + TODOs
e94c7be
@sloriot
use insertion by range
370d913
@sloriot
use a canonical orientation
9ba370a
@sloriot
Merge pull request CGAL#7370 from sloriot/PMP-soup_self_intersections
a216905 
Add self-intersection test and report functions for triangle soups
@sloriot
use self-intersection test for soup for checking the validity of the …
f9668e2 
…output

on some cases it seems twice faster
@sloriot
avoid doing twice the degenerate test
7d1582d
@sloriot
build visitor once for all
822e65b
@sloriot
handle soup as input
9c2de3e
@sloriot
use soup as input/output in example
b488727
@sloriot
repair soup is still recommanded
d979121
@sloriot
WIP: start improving intersect computation
4bc74c3
@sloriot
STILL WIP: copy/paste code for coplanar intersection
842b628
@sloriot
WIP import intersection computation from coref code
39d7bbc
@sloriot
WIP use segments
10252fa
@sloriot
always std::array as cst
5905003
@sloriot
WIP handle coplanar
8107157
@sloriot
WIP handle duplicated intersections + add in intersection list
fa662e7
@sloriot
WIP new coplanar intersection
8bea32d
@sloriot
fix various bug and add debug
8e050bd 
triangle_3_triangle_3_intersection now passes
@sloriot
plug new coplanar triangle intersection code
0bf300d
@sloriot
Copy link
Member Author

sloriot commented Dec 8, 2023

/build:v1

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7614/v1/Manual/index.html

@afabri afabri added pre-approved For pre-approved small features. After 15 days the feature will be accepted. and removed Not yet approved The feature or pull-request has not yet been approved. labels Dec 12, 2023
sloriot and others added 4 commits December 12, 2023 11:53
@sloriot
add missing ref
10f4caa
@sloriot
workaround MSVC 2022 bug
b267b31
@sloriot
remove non needed typenames + missing ref
814a926
@lrineau
Merge remote-tracking branch 'cgal/master' into PMP-BF_autorefine
9a944e5 
# Conflicts:
#	Installation/CHANGES.md
#	Polygon_mesh_processing/examples/Polygon_mesh_processing/CMakeLists.txt
@sloriot
Copy link
Member Author

sloriot commented Dec 18, 2023

Successfully tested in CGAL-6.0-Ic-129

@sloriot sloriot added Accepted small feature and removed pre-approved For pre-approved small features. After 15 days the feature will be accepted. Ready to be tested labels Dec 26, 2023
@sloriot sloriot merged commit 6eff89b into CGAL:master Dec 26, 2023
9 checks passed
@sloriot sloriot deleted the PMP-BF_autorefine branch December 26, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afabri afabri afabri left review comments

@albert-github albert-github albert-github left review comments

Assignees
No one assigned
Labels
Accepted small feature Merged_in_6.0 Pkg::PMP Small feature Tested
Projects
None yet
Milestone
6.0-beta
Development

Successfully merging this pull request may close these issues.
5 participants
@sloriot @afabri @albert-github @MaelRL @lrineau