Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CGAL Lab: fix reading of VTK files #7795

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

lrineau
Copy link
Member

@lrineau lrineau commented Oct 12, 2023

Summary of Changes

CGAL Lab: fix reading of VTK files

  • fix a memory leak
  • allow to read a polygon soup, in addition to surface meshes
  • fix reading of vtp files

Release Management

  • Affected package(s): CGAL Lab
  • License and copyright ownership: unchanged, maintenance by GF

- fix a memory leak
- allow to read a polygon soup, in addition to surface meshes
@lrineau lrineau added this to the 6.0-beta milestone Oct 12, 2023
@lrineau lrineau added the presentation Used to select pull-requests to include in a branch for a presentation label Oct 16, 2023
@sloriot sloriot added the Batch_2 Second Batch of PRs under testing label Oct 16, 2023
@sloriot sloriot added Batch_1 First Batch of PRs under testing Under Testing and removed Batch_2 Second Batch of PRs under testing Batch_1 First Batch of PRs under testing labels Oct 24, 2023
@sloriot sloriot added the Batch_1 First Batch of PRs under testing label Oct 30, 2023
```
            Creating library C:/CGAL_ROOT/CGAL-6.0-Ic-93/cmake/platforms/MSVC-2022-Community-Release/test/Polyhedron_Demo/Release/scene_points_with_normal_item.lib and object C:/CGAL_ROOT/CGAL-6.0-Ic-93/cmake/platforms/MSVC-2022-Community-Release/test/Polyhedron_Demo/Release/scene_points_with_normal_item.exp
   158>Scene_points_with_normal_item.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: virtual __cdecl CGAL::Three::Scene_item_with_properties::~Scene_item_with_properties(void)" (__imp_??1Scene_item_with_properties@Three@CGAL@@UEAA@XZ) referenced in function "int `public: __cdecl Scene_points_with_normal_item::Scene_points_with_normal_item(class dtor$1 const &)'::`1'::dtor$1" (?dtor$1@?0???0Scene_points_with_normal_item@@qeaa@AEBV0@@z@4HA) [C:\CGAL_ROOT\CGAL-6.0-Ic-93\cmake\platforms\MSVC-2022-Community-Release\test\Polyhedron_Demo\scene_points_with_normal_item.vcxproj]
   158>Scene_points_with_normal_item.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl CGAL::Three::Scene_item_with_properties::Scene_item_with_properties(void)" (__imp_??0Scene_item_with_properties@Three@CGAL@@qeaa@XZ) referenced in function "public: __cdecl Scene_points_with_normal_item::Scene_points_with_normal_item(class Scene_points_with_normal_item const &)" (??0Scene_points_with_normal_item@@qeaa@AEBV0@@z) [C:\CGAL_ROOT\CGAL-6.0-Ic-93\cmake\platforms\MSVC-2022-Community-Release\test\Polyhedron_Demo\scene_points_with_normal_item.vcxproj]
   158>C:\CGAL_ROOT\CGAL-6.0-Ic-93\cmake\platforms\MSVC-2022-Community-Release\test\Polyhedron_Demo\Release\scene_points_with_normal_item.dll : fatal error LNK1120: 2 unresolved externals [C:\CGAL_ROOT\CGAL-6.0-Ic-93\cmake\platforms\MSVC-2022-Community-Release\test\Polyhedron_Demo\scene_points_with_normal_item.vcxproj]
```
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.0-Ic-93/Polyhedron_Demo/TestReport_Christo_MSVC-2022-Community-Release.gz
@sloriot sloriot added Under Testing and removed Batch_1 First Batch of PRs under testing labels Oct 30, 2023
@sloriot
Copy link
Member

sloriot commented Nov 2, 2023

Successfully tested in CGAL-6.0-Ic-96

@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Nov 2, 2023
@lrineau lrineau merged commit e92d42f into CGAL:master Nov 6, 2023
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Nov 6, 2023
@lrineau lrineau deleted the CGAL_Lab-fix_VTK_io_plugin-GF branch November 6, 2023 11:55
@lrineau lrineau removed the presentation Used to select pull-requests to include in a branch for a presentation label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants