Aos_2 fixes, by Efi

[efifogel]

Summary of Changes

1. Cleaned up examples
   1. Replaced typedef with using
   2. Replaced CGAL timer with std::chrono
2. Fixed Arr_conic_traits_2
   1. Added missing const qualifier to some interface functions
   2. Fixed orientation parameter in interface functions
3. Fixed inserter (to stream) of General_polygon_set_2 and introduced extractor (from stream)
4. Removed redundant include statement in Surface_sweep_2
5. Fixed Are_mergable_2 functor; added code that tests whether the equality operator (operator==) is supported for the data that extends the curve by the Arr_curve_data_traits_2 class template
6. Introduced Arr_dcel<Traits,V,H,F> and set the old Arr_default_dcel<Traits> to be an alias (using) of Arr_dcel<Traits> (where V, H, and F take default values. This enables the clean extension of Dcel records also for Arrangement_with_history_2 (and Arrangement_on_surface_with_history_2), which requires rebindings of the record types.
7. Made Arrangement_on_surface_with_history_2::Curve_halfedges public, as we enable iterating over such containers of such types.

Release Management

• Affected package(s): Arrangement_on_surface_2, Boolean_set_operations_2, and Surface_sweep_2
• Issue(s) solved (if any): none
• Feature/Small Feature (if any): none
• Link to compiled documentation (obligatory for small feature): none
• License and copyright ownership: TAU

[sloriot]

Successfully tested in CGAL-6.0-Ic-116

[efifogel]

I only converted them to tikz. The pictures remain the same. I did it, because I use the same pictures in the book (CGAL Arrangements and Their Applications), and I'm currently working on the 2nd edition of the book. ____ _ ____ _ /_____/_) o /__________ __ // (____ ( ( ( (_/ (_/-(-'_(/ _/

…

On Wed, 29 Nov 2023 at 10:35, Laurent Rineau ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In Arrangement_on_surface_2/doc/Arrangement_on_surface_2/fig_src/arr_segs.tex <#7841 (comment)>: > +\begin{tikzpicture}[scale=1.0,thick] + \node[point] at ( 1, 3) (a) {}; + \node[point] at ( 2, 4) (b) {}; + \node[point] at ( 0, 6) (c) {}; + \node [point,label={[label distance=0pt]90:{$v_1$}}] at ( 5,11) (1) {}; + \node[point] at ( 9,11) (f) {}; + \node[point] at (12, 8) (g) {}; + \node [point,label={[label distance=0pt]-45:{$v_2$}}] at ( 8, 8) (2) {}; + \node[point] at ( 8, 4) (i) {}; + \node[point] at ( 6, 4) (j) {}; + \node[point] at ( 6, 2) (k) {}; + \node[point] at ( 4, 0) (m) {}; + \node[point] at ( 9, 0) (n) {}; + \node[point] at (11, 2) (o) {}; + \node[point] at (12, 4) (p) {}; + \node[point] at (12, 0) (q) {}; + \node[point] at ( 4, 2) (r) {}; + \node[point] at ( 3, 3) (s) {}; + \node[point] at ( 5, 3) (t) {}; Don't you need to update as well the png versions of those pictures, so that they are updated in the CGAL documentation? — Reply to this email directly, view it on GitHub <#7841 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVBNOBBKUSTANWUGIV4TLDYG3XTLAVCNFSM6AAAAAA6ZRO3X2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONJUG4YDIMRTGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[lrineau]

I agree the pictures look exactly the same as before.