-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CGAL::IO::Internal::read_OBJ(): allow arbitrary whitespace in "f" lines #7848
Merged
lrineau
merged 1 commit into
CGAL:5.5.x-branch
from
sxntxn:OBJ_read_arbitrary_whitespace
Apr 22, 2024
Merged
CGAL::IO::Internal::read_OBJ(): allow arbitrary whitespace in "f" lines #7848
lrineau
merged 1 commit into
CGAL:5.5.x-branch
from
sxntxn:OBJ_read_arbitrary_whitespace
Apr 22, 2024
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Successfully tested in CGAL-6.0-Ic-116 |
@MaelRL what TODO do you have in mind? |
@MaelRL ping!!!! |
This pull-request was previously marked with the label |
MaelRL
approved these changes
Apr 10, 2024
Successfully tested in CGAL-6.0-Ic-224 |
lrineau
added a commit
that referenced
this pull request
Apr 22, 2024
CGAL::IO::Internal::read_OBJ(): allow arbitrary whitespace in "f" lines
lrineau
added a commit
that referenced
this pull request
Apr 22, 2024
CGAL::IO::Internal::read_OBJ(): allow arbitrary whitespace in "f" lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "OBJ" file format does not specify which whitespace to use, so be more tolerant about it.
This allows correct reading of OBJ files where only
\t
(tabulator) is used as a separator in thef
lines.