Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CGAL::IO::Internal::read_OBJ(): allow arbitrary whitespace in "f" lines #7848

Merged
merged 1 commit into from
Apr 22, 2024
Merged

CGAL::IO::Internal::read_OBJ(): allow arbitrary whitespace in "f" lines #7848

merged 1 commit into from
Apr 22, 2024

Conversation

sxntxn
Copy link

@sxntxn sxntxn commented Nov 6, 2023

The "OBJ" file format does not specify which whitespace to use, so be more tolerant about it.
This allows correct reading of OBJ files where only \t (tabulator) is used as a separator in the f lines.

@MaelRL MaelRL self-requested a review November 8, 2023 13:36
@sloriot sloriot added the Batch_2 Second Batch of PRs under testing label Nov 9, 2023
@sloriot sloriot added Under Testing and removed Batch_2 Second Batch of PRs under testing labels Nov 21, 2023
@sloriot
Copy link
Member

sloriot commented Nov 29, 2023

Successfully tested in CGAL-6.0-Ic-116

@sloriot
Copy link
Member

sloriot commented Nov 29, 2023

@MaelRL what TODO do you have in mind?

@sloriot
Copy link
Member

sloriot commented Jan 24, 2024

@MaelRL ping!!!!

@MaelRL MaelRL removed the TODO label Apr 10, 2024
@MaelRL MaelRL changed the base branch from master to 5.5.x-branch April 10, 2024 19:37
@github-actions github-actions bot removed the Tested label Apr 10, 2024
Copy link

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

@MaelRL MaelRL added this to the 5.5.5 milestone Apr 10, 2024
@sloriot
Copy link
Member

sloriot commented Apr 19, 2024

Successfully tested in CGAL-6.0-Ic-224

@lrineau lrineau self-assigned this Apr 19, 2024
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Apr 19, 2024
@lrineau lrineau added the rm only: ready for release branch For the release team only: that indicates that a PR is about to be merged in a release branch label Apr 22, 2024
@lrineau lrineau merged commit c961aee into CGAL:5.5.x-branch Apr 22, 2024
8 of 9 checks passed
lrineau added a commit that referenced this pull request Apr 22, 2024
CGAL::IO::Internal::read_OBJ(): allow arbitrary whitespace in "f" lines
lrineau added a commit that referenced this pull request Apr 22, 2024
CGAL::IO::Internal::read_OBJ(): allow arbitrary whitespace in "f" lines
@lrineau lrineau removed rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' rm only: ready for release branch For the release team only: that indicates that a PR is about to be merged in a release branch labels Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants