-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Arr_observer<Arrangement_2> #7927
Conversation
…that occurs when using observers.
…curs when using observers; renamed Arr_observer => Aos_observer, and introduced Arr_observer for backward compatibility.
* | ||
* `Aos_observer` serves as an abstract base class for all observer classes that | ||
* are attached to an arrangement instance of type `Arrangement` and receive | ||
* notifications from the arrangement. This base class handles the attachment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 spaces should be 1 space (also on other places)
/*! the \f$ x\f$-monotone curve type. */ | ||
typedef typename Arrangement_2::X_monotone_curve_2 X_monotone_curve_2; | ||
|
||
/*! */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be filled in? (also on the next few lines?)
Vertex_handle v1, Vertex_handle v2); | ||
|
||
/*! issued immediately after a new edge `e` has been created. The halfedge that | ||
* is sent to this function is always directed from `v1` to `v2` (see above). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better refer to the function name as e.g. due to sorting the order in the documentation can change.
#include <CGAL/Arr_enums.h> | ||
|
||
/*! \file | ||
* Definition of the Aos_observer<Arrangement> base class. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
backticks around Aos_observer<Arrangement>
?
/// \name Modifying the associated arrangement. | ||
//@{ | ||
|
||
/*! Get the associated arrangement (non-const version). */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"non-const" version?
/*! | ||
* Notification before the creation of a new vertex. | ||
* \param p The point to be associated with the vertex. | ||
* This point cannot lies on the surface boundaries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"lies" -> "lie"
{} | ||
|
||
/*! Notification before the creation of a new boundary vertex. | ||
* \param p The on the surface boundary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The on" ?
virtual void after_create_boundary_vertex(Vertex_handle /* v */) {} | ||
|
||
/*! Notification before the creation of a new edge. | ||
* \param c The x-monotone curve to be associated with the edge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x-monotone
elsewhere it is like a formula \f$ x\f$-monotone
(also at other places)
* \param v1 A handle to the first end-vertex of the edge. | ||
* \param v2 A handle to the second end-vertex of the edge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 end-vertices?
/*! issued just before outer ccb `h` inside a face `f` is split into two, as a | ||
* result of the removal of the edge `e` from the arrangement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ccb
or CCB
(just above and in another file I saw CCB
)
Error in the documentation : |
All fixed. Thanks.
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Tue, 12 Dec 2023 at 11:42, albert-github ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
Arrangement_on_surface_2/doc/Arrangement_on_surface_2/CGAL/Aos_observer.h
<#7927 (comment)>:
> @@ -0,0 +1,409 @@
+namespace CGAL {
+
+/*! \ingroup PkgArrangementOnSurface2Ref
+ *
+ * \anchor arr_refaos_obs
+ *
+ * `Aos_observer` serves as an abstract base class for all observer classes that
+ * are attached to an arrangement instance of type `Arrangement` and receive
+ * notifications from the arrangement. This base class handles the attachment
2 spaces should be 1 space (also on other places)
------------------------------
In
Arrangement_on_surface_2/doc/Arrangement_on_surface_2/CGAL/Aos_observer.h
<#7927 (comment)>:
> +class Aos_observer {
+public:
+
+ /// \name Types
+ /// @{
+
+ /*! the type of the associated arrangement. */
+ typedef unspecified_type Arrangement_2;
+
+ /*! the point type. */
+ typedef typename Arrangement_2::Point_2 Point_2;
+
+ /*! the \f$ x\f$-monotone curve type. */
+ typedef typename Arrangement_2::X_monotone_curve_2 X_monotone_curve_2;
+
+ /*! */
To be filled in? (also on the next few lines?)
------------------------------
In
Arrangement_on_surface_2/doc/Arrangement_on_surface_2/CGAL/Aos_observer.h
<#7927 (comment)>:
> + Arr_parameter_space ps_x,
+ Arr_parameter_space ps_y);
+
+ /*! issued immediately after a new vertex `v` has been created. Note that the
+ * vertex still has no incident edges and is not connected to any other vertex.
+ */
+ virtual void after_create_boundary_vertex(Vertex_handle v);
+
+ /*! issued just before a new edge that corresponds to the \f$ x\f$-monotone
+ * curve `c` and connects the vertices `v1` and `v2` is created.
+ */
+ virtual void before_create_edge(const X_monotone_curve_2& c,
+ Vertex_handle v1, Vertex_handle v2);
+
+ /*! issued immediately after a new edge `e` has been created. The halfedge that
+ * is sent to this function is always directed from `v1` to `v2` (see above).
Better refer to the function name as e.g. due to sorting the order in the
documentation can change.
------------------------------
In Arrangement_on_surface_2/include/CGAL/Aos_observer.h
<#7927 (comment)>:
> +//
+//
+// Author(s): Ron Wein ***@***.***>
+// Efi Fogel ***@***.***>
+
+#ifndef CGAL_AOS_OBSERVER_H
+#define CGAL_AOS_OBSERVER_H
+
+#include <CGAL/license/Arrangement_on_surface_2.h>
+
+#include <CGAL/disable_warnings.h>
+
+#include <CGAL/Arr_enums.h>
+
+/*! \file
+ * Definition of the Aos_observer<Arrangement> base class.
backticks around Aos_observer<Arrangement>?
------------------------------
In Arrangement_on_surface_2/include/CGAL/Aos_observer.h
<#7927 (comment)>:
> + p_arr->_register_observer(this);
+ }
+
+ /*! Destructor. */
+ virtual ~Aos_observer()
+ {
+ // Unregister the observer object from the arrangement.
+ if (p_arr != nullptr)
+ p_arr->_unregister_observer(this);
+ }
+ //@}
+
+ /// \name Modifying the associated arrangement.
+ //@{
+
+ /*! Get the associated arrangement (non-const version). */
"non-const" version?
------------------------------
In Arrangement_on_surface_2/include/CGAL/Aos_observer.h
<#7927 (comment)>:
> +
+ /*! Notification after the arrangement is cleared. */
+ virtual void after_clear() {}
+
+ /*! Notification before a global operation modifies the arrangement. */
+ virtual void before_global_change() {}
+
+ /*! Notification after a global operation is completed. */
+ virtual void after_global_change() {}
+ //@}
+
+ /// \name Notification functions on observer attachment or detachment.
+ //@{
+
+ /*! Notification before the observer is attached to an arrangement.
+ * \param arr The arrangement we are about to attach the observer to.
is the sentence complete? (probably text "an arrangement" is missing)
------------------------------
In Arrangement_on_surface_2/include/CGAL/Aos_observer.h
<#7927 (comment)>:
> +
+ /// \name Notification functions on observer attachment or detachment.
+ //@{
+
+ /*! Notification before the observer is attached to an arrangement.
+ * \param arr The arrangement we are about to attach the observer to.
+ */
+ virtual void before_attach(const Arrangement_2& /* arr */) {}
+
+ /*! Notification after the observer has been attached to an arrangement. */
+ virtual void after_attach() {}
+
+ /*! Notification before the observer is detached from the arrangement. */
+ virtual void before_detach() {}
+
+ /*! Notification after the observer has been detached to the arrangement. */
"to the arrangement" -> "from the arrangement"
------------------------------
In Arrangement_on_surface_2/include/CGAL/Aos_observer.h
<#7927 (comment)>:
> + virtual void after_attach() {}
+
+ /*! Notification before the observer is detached from the arrangement. */
+ virtual void before_detach() {}
+
+ /*! Notification after the observer has been detached to the arrangement. */
+ virtual void after_detach() {}
+ //@}
+
+ /// \name Notification functions on local changes in the arrangement.
+ //@{
+
+ /*!
+ * Notification before the creation of a new vertex.
+ * \param p The point to be associated with the vertex.
+ * This point cannot lies on the surface boundaries.
"lies" -> "lie"
------------------------------
In Arrangement_on_surface_2/include/CGAL/Aos_observer.h
<#7927 (comment)>:
> +
+ /*!
+ * Notification before the creation of a new vertex.
+ * \param p The point to be associated with the vertex.
+ * This point cannot lies on the surface boundaries.
+ */
+ virtual void before_create_vertex(const Point_2& /* p */) {}
+
+ /*! Notification after the creation of a new vertex.
+ * \param v A handle to the created vertex.
+ */
+ virtual void after_create_vertex(Vertex_handle /* v */)
+ {}
+
+ /*! Notification before the creation of a new boundary vertex.
+ * \param p The on the surface boundary.
"The on" ?
------------------------------
In Arrangement_on_surface_2/include/CGAL/Aos_observer.h
<#7927 (comment)>:
> + * \param ps_x The boundary condition of the vertex in x.
+ * \param ps_y The boundary condition of the vertex in y.
+ */
+ virtual void before_create_boundary_vertex(const X_monotone_curve_2& /* cv */,
+ Arr_curve_end /* ind */,
+ Arr_parameter_space /* ps_x */,
+ Arr_parameter_space /* ps_y */)
+ {}
+
+ /*! Notification after the creation of a new vertex at infinity.
+ * \param v A handle to the created vertex.
+ */
+ virtual void after_create_boundary_vertex(Vertex_handle /* v */) {}
+
+ /*! Notification before the creation of a new edge.
+ * \param c The x-monotone curve to be associated with the edge.
x-monotone elsewhere it is like a formula \f$ x\f$-monotone (also at
other places)
------------------------------
In Arrangement_on_surface_2/include/CGAL/Aos_observer.h
<#7927 (comment)>:
> + * \param v1 A handle to the first end-vertex of the edge.
+ * \param v2 A handle to the second end-vertex of the edge.
2 end-vertices?
------------------------------
In
Arrangement_on_surface_2/doc/Arrangement_on_surface_2/CGAL/Aos_observer.h
<#7927 (comment)>:
> + /*! issued just before outer ccb `h` inside a face `f` is split into two, as a
+ * result of the removal of the edge `e` from the arrangement.
ccb or CCB (just above and in another file I saw CCB)
—
Reply to this email directly, view it on GitHub
<#7927 (review)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVBNOESVJ7F6FRIBJWQQLLYJARHPAVCNFSM6AAAAABAQVFZKGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONZWHE3TKMRQG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
It is defined in one place only, so I don't understand how or why this
warning message is generated
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Wed, 13 Dec 2023 at 09:42, Andreas Fabri ***@***.***> wrote:
Error in the documentation
<https://cgal.geometryfactory.com/CGAL/Manual_doxygen_test/CGAL-6.0-Ic-127/>
: CGAL-6.0-Ic-127/doc/scripts/doc_1_8_13/doc_tags/Arrangement_on_surface_2.tag:11511:
warning: Duplicate anchor arr_refarr_obs found
—
Reply to this email directly, view it on GitHub
<#7927 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVBNOD2GU6DKRIW3BEWLTTYJFL7RAVCNFSM6AAAAABAQVFZKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJTGQYTCNZXG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Regarding the documentation warning when running doxygen 1.8.13
|
Indeed, when running locally using doxygen version 1.9.7 the warning is
*not* generated.
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Wed, 13 Dec 2023 at 13:59, albert-github ***@***.***> wrote:
Regarding the documentation warning when running doxygen 1.8.13
- this might be a bug in the doxygen 1.8.13 version
- is thus pull request just for the 6.0 and newer versions or will it
also be in the 5.5 / 5.6 CGAL versions
- in case it is only intended for the 6.0 and newer versions there
won't be a problem as the doxygen 1.9.6 version will be used here (to the
best of my knowledge)
- in case it is also back-ported to 5.5 and 5.6 we have to see what
the effect on the documentation is
—
Reply to this email directly, view it on GitHub
<#7927 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVBNOGA7WTKED3TXTL6LHTYJGKCDAVCNFSM6AAAAABAQVFZKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJTG44DMMBQGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
…t has to do with observers
New warnings:
|
Might also be responsible for runtime errors here: |
…arr) of all observers (derived from Aos_observer)
clang is good (it was clang that detected this problem, right?)
This was a real problem.
The basic idea behind this entire fix is that everything that has to do
with the observer is based on the very base Arrangement_on_surface type.
For example, if we have A1 derived from A2 derived ... derived from
CGAL::Arrangement_on_surface_2, the observer is based on the latter, and so
are the types of the parameters of the virtual functions that accept an
arrangement type.)
Anyway, I fixed this last problem; please try again.
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Thu, 14 Dec 2023 at 15:31, Sebastien Loriot ***@***.***> wrote:
New warnings:
/mnt/testsuite/include/CGAL/Arr_trapezoid_ric_point_location.h:241:16: warning: 'CGAL::Arr_trapezoid_ric_point_location<CGAL::Arrangement_2<CGAL::Arr_segment_traits_2<>>>::before_assign' hides overloaded virtual function [-Woverloaded-virtual]
241 | virtual void before_assign (const Arrangement_on_surface_2& arr)
| ^
/mnt/testsuite/test/Arrangement_on_surface_2/test_vert_ray_shoot_vert_segments.cpp:60:10: note: in instantiation of template class 'CGAL::Arr_trapezoid_ric_point_location<CGAL::Arrangement_2<CGAL::Arr_segment_traits_2<>>>' requested here
60 | RIC_pl ric_pl(arr);
| ^
/mnt/testsuite/include/CGAL/Aos_observer.h:139:16: note: hidden overloaded virtual function 'CGAL::Aos_observer<CGAL::Arrangement_on_surface_2<CGAL::Arr_segment_traits_2<>, CGAL::Arr_bounded_planar_topology_traits_2<CGAL::Arr_segment_traits_2<>>>>::before_assign' declared here: type mismatch at 1st parameter ('const Arrangement_2 &' (aka 'const CGAL::Arrangement_on_surface_2<CGAL::Arr_segment_traits_2<>, CGAL::Arr_bounded_planar_topology_traits_2<CGAL::Arr_segment_traits_2<>>> &') vs 'const Arrangement_on_surface_2 &' (aka 'const CGAL::Arrangement_2<CGAL::Arr_segment_traits_2<>> &'))
139 | virtual void before_assign(const Arrangement_2& /* arr */) {}
| ^
In file included from /mnt/testsuite/test/Arrangement_on_surface_2/test_vert_ray_shoot_vert_segments.cpp:6:
/mnt/testsuite/include/CGAL/Arr_trapezoid_ric_point_location.h:263:16: warning: 'CGAL::Arr_trapezoid_ric_point_location<CGAL::Arrangement_2<CGAL::Arr_segment_traits_2<>>>::before_attach' hides overloaded virtual function [-Woverloaded-virtual]
263 | virtual void before_attach (const Arrangement_on_surface_2& arr)
—
Reply to this email directly, view it on GitHub
<#7927 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVBNOBOHW5XOTPZFXSJCITYJL5TZAVCNFSM6AAAAABAQVFZKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJVHA3DAMBSGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
The run time error does not seem related, but who knows... let's try one
thing at a time.
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Thu, 14 Dec 2023 at 15:31, Sebastien Loriot ***@***.***> wrote:
Might also be responsible for runtime errors here:
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.0-Ic-127/Surface_sweep_2/TestReport_lrineau_Ubuntu-Latest.gz
—
Reply to this email directly, view it on GitHub
<#7927 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVBNOAH4FCCYGZ7NWWMFGDYJL5UXAVCNFSM6AAAAABAQVFZKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJVHA3DANBRGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Now that we use C++11 or later, prefer the use of |
New warnings:
|
Right.
It doesn't end there.
I went over all observers and fixed the definition of the ised types within
to use the base arrangement.
All tests pass, but more changes might be needed.
Anyhow, the code is ready.
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Tue, 19 Dec 2023 at 18:24, Sebastien Loriot ***@***.***> wrote:
New warnings:
-
/Users/magritte/cgal_root/CGAL-6.0-Ic-131/include/CGAL/Arr_trapezoid_ric_point_location.h:301:16:
warning:
'CGAL::Arr_trapezoid_ric_point_location<CGAL::Arrangement_with_history_2<CGAL::Arr_segment_traits_2<>>>::before_split_edge'
hides overloaded virtual function [-Woverloaded-virtual] virtual void
before_split_edge (Halfedge_handle e,
-
/Users/magritte/cgal_root/CGAL-6.0-Ic-131/include/CGAL/Arr_trapezoid_ric_point_location.h:325:16:
warning:
'CGAL::Arr_trapezoid_ric_point_location<CGAL::Arrangement_with_history_2<CGAL::Arr_segment_traits_2<>>>::before_merge_edge'
hides overloaded virtual function [-Woverloaded-virtual] virtual void
before_merge_edge (Halfedge_handle e1,
—
Reply to this email directly, view it on GitHub
<#7927 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVBNOATMPAMDEBHZXZ3M6TYKG5SVAVCNFSM6AAAAABAQVFZKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRTGA4DGNBUGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Yep.
I added the override specifier to all virtual functions of the observer.
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Tue, 19 Dec 2023 at 16:22, Laurent Rineau ***@***.***> wrote:
New warnings:
/mnt/testsuite/include/CGAL/Arr_trapezoid_ric_point_location.h:241:16: warning: 'CGAL::Arr_trapezoid_ric_point_location<CGAL::Arrangement_2<CGAL::Arr_segment_traits_2<>>>::before_assign' hides overloaded virtual function [-Woverloaded-virtual]
241 | virtual void before_assign (const Arrangement_on_surface_2& arr)
| ^
Now that we use C++11 or later, prefer the use of override instead of
virtual. That way all compilers will emit an error if a member function
supposed to override a virtual function of a base class have a mismatch in
the parameters. The specifier virtual is only for the base function of
the hierarchy.
—
Reply to this email directly, view it on GitHub
<#7927 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVBNOHWXX6VZLSKHSB4TMTYKGPKDAVCNFSM6AAAAABAQVFZKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRSHA2TEMJWG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
New warnings:
|
Yep; forgot one override.
I fixed it.
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Wed, 27 Dec 2023 at 14:58, Sebastien Loriot ***@***.***> wrote:
New warnings:
- /Users/magritte/cgal_root/CGAL-6.0-Ic-137/test/Arrangement_on_surface_2/test_observer.cpp:406:16:
warning: 'after_merge_outer_ccb' overrides a member function but is not
marked 'override' [-Winconsistent-missing-override]
- /Users/magritte/cgal_root/CGAL-6.0-Ic-137/include/CGAL/Aos_observer.h:451:16:
note: overridden virtual function is here virtual void
after_merge_outer_ccb(Face_handle /* f */,
—
Reply to this email directly, view it on GitHub
<#7927 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVBNOGXTCEAIHL7M5CDS33YLQLRHAVCNFSM6AAAAABAQVFZKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZQGI4DIOBYGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Tests are looking OK in CGAL-6.0-Ic-156 but we are still having a segfault on Arm64e here I should have a look locally. |
The issue is not specific to macOs but requires to disable GMP. The branch can be merged I'll handle the issue in another branch. |
Any hint for reproduction on a non-arm machine?
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Wed, 24 Jan 2024 at 15:38, Sebastien Loriot ***@***.***> wrote:
The issue is not specific to macOs but requires to disable GMP. The branch
can be merged I'll handle the issue in another branch.
—
Reply to this email directly, view it on GitHub
<#7927 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVBNOAKJHXIA636VCC7H7DYQEFENAVCNFSM6AAAAABAQVFZKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBYGE2DCMBQHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
The issue comes AFAIU from the reading of input into |
oh, so it seems unrelated to the arr. observer.
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Wed, 24 Jan 2024 at 16:05, Sebastien Loriot ***@***.***> wrote:
The issue comes AFAIU from the reading of input into Quotient<MP_Float>.
If you configure the test with -DCGAL_DISABLE_GMP=ON you should be able
to reproduce it on your machine.
—
Reply to this email directly, view it on GitHub
<#7927 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVBNOFSSHT4VLFDWPFDTZTYQEIJHAVCNFSM6AAAAABAQVFZKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBYGE4DQNJYHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
It's a bug in |
Summary of Changes
The first 2 items eliminate the error-prone c-type casting that was used to define observers.
The 3rd item is for backward compatibility.
Release Management