New function PMP::add_bbox(face_graph) that adds bbox to face graph
#8018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the bbox can be : * triangulated or not * tight or not
lrineau
reviewed
Feb 9, 2024
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/bbox.h
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
a NP that already existed before this PR
and remove dependency on T2
janetournois
force-pushed
the
PMP-add_bbox_to_face_graph-jtournois
branch
from
7dfea56 to
c23db55
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
/force-build:v0 |
|
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8018/v0/Manual/index.html |
MaelRL
added
Not yet approved
|
tests failing in CGAL-6.0-Ic-191 (BGL for example) |
sloriot
added
Under Testing
pre-approved
sloriot
added
Batch_1
|
Successfully tested in 6.0-Ic-197 |
sloriot
added
Tested
and removed
Ready to be tested
Batch_1
MaelRL
added
Accepted small feature
and removed
Not yet approved
lrineau
added
the
rm only: ready for master
lrineau
removed
the
rm only: ready for master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The bbox can be :
Changes in the API:
PMP::add_bbox(face_graph)scale(factor)toBbox_2andBbox_3bbox_scalingnamed parameter toPMP::bbox(face_graph)CGAL::make_ hexahedron(CGAL::Iso_cuboid_3, Graph&, NP)withdo_not_triangulateas NPRelease Management
Affected package(s): PMP, BGL
Small Feature : wiki -- pre-approval: 2024/03/14
Link to compiled documentation
License and copyright ownership: unchanged