Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polygon: Avoid stackoverflow when summing exact numbers #8052

Merged
merged 4 commits into from
Mar 22, 2024
Merged

Polygon: Avoid stackoverflow when summing exact numbers #8052

merged 4 commits into from
Mar 22, 2024

Conversation

afabri
Copy link
Member

@afabri afabri commented Feb 28, 2024

Summary of Changes

When summing the areas of triangles we create a linear DAG where the recursive deallocation will lead to a stackoverflow.

Release Management

  • Affected package(s): Polygon
  • License and copyright ownership: unchanged

@afabri afabri added this to the 5.6.2 milestone Feb 28, 2024
@afabri afabri requested a review from sloriot February 28, 2024 14:30
@sloriot sloriot linked an issue Feb 28, 2024 that may be closed by this pull request
Access Violation on CGAL::Intersect with specific inputs #7934
Closed
@sloriot
Copy link
Member

sloriot commented Feb 29, 2024 •
edited by afabri
Loading

Polygon test failing in CGAL-6.0-Ic-183

@sloriot sloriot modified the milestones: 5.6.2, 5.5.5 Mar 6, 2024
@sloriot
Copy link
Member

sloriot commented Mar 7, 2024

CGAL-6.0-Ic-188 Boolean_set_operations_2 failed (issue with GMPXX and exact() AFAIU)

@sloriot sloriot added Under Testing Batch_1 First Batch of PRs under testing and removed Tests failing Under Testing labels Mar 14, 2024
@sloriot
Copy link
Member

sloriot commented Mar 21, 2024

Successfully tested in 6.0-Ic-197

@sloriot sloriot added Tested and removed Ready to be tested Batch_1 First Batch of PRs under testing labels Mar 21, 2024
@lrineau lrineau self-assigned this Mar 21, 2024
@lrineau lrineau added rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' rm only: ready for release branch For the release team only: that indicates that a PR is about to be merged in a release branch labels Mar 21, 2024
@lrineau lrineau merged commit 8cab90e into CGAL:5.5.x-branch Mar 22, 2024
8 checks passed
lrineau added a commit that referenced this pull request Mar 22, 2024
@lrineau
Merge pull request #8052 from afabri/Polygon-exact_area-GF
7a17b47 
Polygon: Avoid stackoverflow when summing exact numbers

# Conflicts:
#	Polygon/include/CGAL/Polygon_2_algorithms.h
#	Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/measure.h
@lrineau lrineau removed rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' rm only: ready for release branch For the release team only: that indicates that a PR is about to be merged in a release branch labels Mar 22, 2024
@lrineau lrineau deleted the Polygon-exact_area-GF branch March 22, 2024 08:22
@lrineau lrineau mentioned this pull request Oct 11, 2024
Closed
@afabri afabri mentioned this pull request Oct 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloriot sloriot sloriot approved these changes

Assignees

@lrineau lrineau

Labels
Bug Merged_in_5.5.5 Merged_in_5.6.2 Merged_in_6.0 Pkg::Polygon Tested
Projects
None yet
Milestone
5.5.5
Development

Successfully merging this pull request may close these issues.

Access Violation on CGAL::Intersect with specific inputs
3 participants
@afabri @sloriot @lrineau