Mesh_3 - fix mesher using the one_step() loop
#8072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her_3 to make sure the input c3t3 is fully clean before starting refinement
we actually need to clear C3T3 from all facets and cells, including the infinite ones. Indeed, extra point insertions during (e.g.) the initialization step may have made invalid the metadata in all cells, including the infinite ones
|
Seems to break generators, periodic_3, smds, ... |
sloriot
reviewed
Mar 21, 2024
Co-authored-by: Sebastien Loriot <[email protected]>
|
Unused |
|
Successfully tested in CGAL-6.0-Ic-200 |
lrineau
added
the
rm only: ready for master
lrineau
added a commit
that referenced
this pull request
Mar 26, 2024
…tournois Mesh_3 - fix mesher using the `one_step()` loop # Conflicts: # Mesh_3/include/CGAL/Mesh_3/Triangulation_helpers.h
lrineau
removed
the
rm only: ready for master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The demo and one step are using Mesh_3 via its
one_step()loop.After inserting the initial points, the C3t3 may be invalid because point insertions have invalidated the cells and cells markers.
Before starting refinement, it is needed to reset the C3t3 by clearing it from its facets and cells. This is now done inside the constructor of
Mesher_3, instead of insiderefine_mesh_3().It hence becomes robust to any custom initialization.
Notes :
init_c3t3()that ensures that no vertices are inserted inside protecting ballsRelease Management