Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed order of Qt6 components in find_package(Qt6 ....) #8098

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Fixed order of Qt6 components in find_package(Qt6 ....) #8098

merged 1 commit into from
Apr 10, 2024

Conversation

efifogel
Copy link
Member

Summary of Changes

Fixed the order of Qt6 components in the find_package(Qt6 COMPONENTS ....)

Release Management

  • Affected package(s): Installation
  • Issue(s) solved (if any): fix Simple drawing fails with Qt6 6.8.0 #8058
  • Feature/Small Feature (if any):
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership:

lrineau
lrineau approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@lrineau lrineau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am really surprised the order changes anything, but I saw the effect myself on Efi's machine.

@lrineau lrineau added this to the 6.0-beta milestone Mar 26, 2024
@sloriot
Copy link
Member

sloriot commented Apr 10, 2024

Successfully tested in CGAL-6.0-Ic-21[56]

@lrineau lrineau self-assigned this Apr 10, 2024
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Apr 10, 2024
@lrineau lrineau merged commit afad4a1 into CGAL:master Apr 10, 2024
8 checks passed
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Apr 10, 2024
@sloriot sloriot deleted the Installation-qt6-efif branch October 14, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrineau lrineau lrineau approved these changes

Assignees

@lrineau lrineau

Labels
Bug CMake scripts Merged_in_6.0 Qt6 Tested
Projects
None yet
Milestone
6.0-beta
Development

Successfully merging this pull request may close these issues.

Simple drawing fails with Qt6 6.8.0
3 participants
@efifogel @sloriot @lrineau