Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra parameters to the corefinement visitor to handle non-manifold output #8142

Merged
merged 12 commits into from
May 15, 2024
Merged

Add extra parameters to the corefinement visitor to handle non-manifold output #8142

merged 12 commits into from
May 15, 2024

Conversation

sloriot
Copy link
Member

@sloriot sloriot commented Apr 15, 2024 •
edited by MaelRL
Loading

Summary of Changes

CGAL lacks a data structure for non-manifold meshes. This PR adds a workaround to handle non-manifold output of a Boolean Operations.

Release Management

  • Affected package(s): PMP
  • Issue(s) solved (if any): NA
  • Feature/Small Feature (if any): here -- pre approved 2024-04-18
  • Link to compiled documentation (obligatory for small feature): new class
  • License and copyright ownership: GF

@sloriot sloriot added Enhancement Pkg::PMP rm only: release blocker For the release team only: the next release requires this issue/PR to be solved/merge labels Apr 15, 2024
@MaelRL MaelRL added this to the 6.0-beta milestone Apr 15, 2024
@sloriot
Copy link
Member Author

sloriot commented Apr 15, 2024

/build:v1

@github-actions GitHub Actions
Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8142/v1/Manual/index.html

@MaelRL MaelRL added Not yet approved The feature or pull-request has not yet been approved. Small feature labels Apr 15, 2024
MaelRL
MaelRL reviewed Apr 15, 2024
View reviewed changes
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/corefinement.h Show resolved Hide resolved
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/corefinement.h Outdated Show resolved Hide resolved
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/corefinement.h Outdated Show resolved Hide resolved
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/corefinement.h Show resolved Hide resolved
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/corefinement.h Show resolved Hide resolved
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/corefinement.h Outdated Show resolved Hide resolved
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/corefinement.h Outdated Show resolved Hide resolved
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/corefinement.h Show resolved Hide resolved
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/corefinement.h Outdated Show resolved Hide resolved
@MaelRL MaelRL added pre-approved For pre-approved small features. After 15 days the feature will be accepted. Ready to be tested and removed Not yet approved The feature or pull-request has not yet been approved. labels Apr 18, 2024
@sloriot
Copy link
Member Author

sloriot commented Apr 19, 2024

Successfully tested in 6.0-Ic-224

@lrineau lrineau self-assigned this Apr 19, 2024
@MaelRL MaelRL added Accepted small feature and removed pre-approved For pre-approved small features. After 15 days the feature will be accepted. labels May 2, 2024
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label May 2, 2024
@lrineau lrineau merged commit 0dcb83b into CGAL:master May 15, 2024
9 checks passed
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label May 16, 2024
@lrineau lrineau deleted the PMP-coref_nm_out branch May 16, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaelRL MaelRL MaelRL left review comments

Assignees

@lrineau lrineau

Labels
Accepted small feature Enhancement Merged_in_6.0 Pkg::PMP rm only: release blocker For the release team only: the next release requires this issue/PR to be solved/merge Small feature Tested
Projects
None yet
Milestone
6.0-beta
Development

Successfully merging this pull request may close these issues.
3 participants
@sloriot @MaelRL @lrineau