Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polygon_repair:: Use move semantics; Add Polygon_2::reserve() #8143

Merged
merged 17 commits into from
Apr 25, 2024
Merged

Polygon_repair:: Use move semantics; Add Polygon_2::reserve() #8143

merged 17 commits into from
Apr 25, 2024

Conversation

afabri
Copy link
Member

@afabri afabri commented Apr 15, 2024 •
edited
Loading

Summary of Changes

Avoid copying sequences of points. Also add a function to Polygon_2 that calls reserve() in case it is offered by the underlying container.

Release Management

  • Affected package(s): Polygon_repair
  • License and copyright ownership: unchanged

@afabri afabri added this to the 6.0-beta milestone Apr 15, 2024
@afabri afabri requested a review from sloriot April 15, 2024 10:34
@lrineau lrineau added the Not yet approved The feature or pull-request has not yet been approved. label Apr 15, 2024
@lrineau lrineau self-requested a review April 15, 2024 12:04
@sloriot
Copy link
Member

sloriot commented Apr 24, 2024

Successfully tested in CGAL-6.0-Ic-228

@lrineau lrineau requested a review from sloriot April 25, 2024 09:27
@lrineau lrineau self-assigned this Apr 25, 2024
@lrineau lrineau added rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' and removed Not yet approved The feature or pull-request has not yet been approved. labels Apr 25, 2024
@lrineau lrineau merged commit 3545f00 into CGAL:master Apr 25, 2024
9 checks passed
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Apr 25, 2024
@lrineau lrineau deleted the Polygon_repair-less_copies-GF branch April 25, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrineau lrineau lrineau left review comments

@sloriot sloriot Awaiting requested review from sloriot

Assignees

@lrineau lrineau

Labels
Merged_in_6.0 Pkg::Polygon_repair Speed Tested
Projects
None yet
Milestone
6.0-beta
Development

Successfully merging this pull request may close these issues.
3 participants
@afabri @sloriot @lrineau