Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Triangulation on Sphere: Fix I/O #8201

Merged
merged 15 commits into from
Jun 10, 2024
Merged

Triangulation on Sphere: Fix I/O #8201

merged 15 commits into from
Jun 10, 2024

Conversation

afabri
Copy link
Member

@afabri afabri commented May 14, 2024 •
edited
Loading

Summary of Changes

Add test case that illustrates Issue #8200.

Todo

  • Fix ToS2::is_valid() which does not compile (it is in operator>>(..))
  • Fix skip_vertex
  • Check why ghost faces are not the same after writing and reading back.

Release Management

@afabri afabri self-assigned this May 14, 2024
@afabri afabri added this to the 6.0-beta milestone May 14, 2024
@afabri afabri changed the title Triangulation on Sphere: Fix I/O WIP Triangulation on Sphere: Fix I/O May 14, 2024
@afabri afabri changed the title WIP Triangulation on Sphere: Fix I/O Triangulation on Sphere: Fix I/O May 14, 2024
@afabri afabri requested a review from MaelRL May 14, 2024 13:57
@afabri afabri marked this pull request as ready for review May 14, 2024 14:05
@afabri afabri changed the base branch from master to 5.5.x-branch May 14, 2024 15:01
@MaelRL MaelRL added the Not yet approved The feature or pull-request has not yet been approved. label May 15, 2024
@MaelRL MaelRL modified the milestones: 6.0-beta, 5.5.5 May 15, 2024
@afabri
Copy link
Member Author

afabri commented May 16, 2024

@MaelRL can you have a look at the assertion. My guess is that the is_valid() function has a bug, as it did not even compile before I started this pull request.

@sloriot
Copy link
Member

sloriot commented May 21, 2024 •
edited by afabri
Loading

As you expect still some error in ToS tests of CGAL-6.0-Ic-245

   ERROR:      execution   of  issue_8200 in 0.0147595 s : Failed 
CGAL error: assertion violation!

@MaelRL MaelRL removed Not yet approved The feature or pull-request has not yet been approved. Tests failing labels Jun 4, 2024
@MaelRL MaelRL removed their request for review June 5, 2024 07:28
@sloriot
Copy link
Member

sloriot commented Jun 10, 2024

Successfully tested in CGAL-6.0-Ic-262

lrineau pushed a commit to lrineau/cgal that referenced this pull request Jun 10, 2024
@sloriot
Merge pull request CGAL#8201 from afabri/ToS-IO-GF
c36ede0 
Triangulation on Sphere: Fix I/O
@lrineau lrineau added rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' rm only: ready for release branch For the release team only: that indicates that a PR is about to be merged in a release branch labels Jun 10, 2024
lrineau added a commit that referenced this pull request Jun 10, 2024
@lrineau
Merge pull request #8201 from afabri/ToS-IO-GF
561e7f1 
Triangulation on Sphere: Fix I/O

# Conflicts:
#	Triangulation_on_sphere_2/include/CGAL/Delaunay_triangulation_on_sphere_2.h
#	Triangulation_on_sphere_2/include/CGAL/Triangulation_on_sphere_2.h
#	Triangulation_on_sphere_2/test/Triangulation_on_sphere_2/CMakeLists.txt
@lrineau lrineau merged commit 09d29da into CGAL:5.5.x-branch Jun 10, 2024
8 checks passed
@lrineau lrineau removed rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' rm only: ready for release branch For the release team only: that indicates that a PR is about to be merged in a release branch labels Jun 10, 2024
@lrineau lrineau deleted the ToS-IO-GF branch June 10, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@afabri afabri

@MaelRL MaelRL

Labels
Bug Merged_in_5.5.5 Merged_in_5.6.2 Merged_in_6.0 Pkg::Triangulation_on_sphere_2 Tested
Projects
None yet
Milestone
5.5.5
Development

Successfully merging this pull request may close these issues.

Triangulation on Sphere: operator>>
4 participants
@afabri @sloriot @MaelRL @lrineau