CGAL Lab, Surface_mesh item: Fix using the fcolor pmap when there is no face color #8228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrineau
added
the
rm only: release blocker
sloriot
approved these changes
May 28, 2024
lrineau
changed the title
lrineau
changed the title
|
Successfully tested in CGAL-6.0-Ic-256 |
lrineau
added
the
rm only: ready for master
lrineau
removed
the
rm only: ready for master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This is a quick band aid such that the demo can be used. The proper fix would be to not have a Boolean on whether the pmap is defined as item member, while also passing the pmap as parameter of functions...
Release Management
Lab