Mesh_3 - bug fixes for edge_distance and edge_min_size
#8405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Mesh_3 testsuite is currrently running locally on my machine |
|
|
…x to be valid use minimal_size instead of 0 fix 5e64bce fix approx_is_too_large(edge) that needs the corresponding curve_index to be valid and fix the default edge_min_size
janetournois
force-pushed
the
Mesh_3-fixes_for_self_intersecting_data-jtournois
branch
from
64d09e9 to
fd498e3
Compare
|
Tests failing in CGAL-6.0-Ic-305 See here |
let's keep the minimal weight as given in meshing criteria
|
Successfully tested in CGAL-6.0-Ic-311 |
sloriot
added a commit
that referenced
this pull request
Dec 6, 2024
…ith_aabb_tree` (#8627) ## Summary of Changes Using `min_size` with `Sizing_field_with_aabb_tree` (and probably other sizing fields) could lead to `CGAL_error_msg()` though the scenario was "normal". This PR fixes this issue (and completes PR #8405) ## Release Management * Affected package(s): Mesh_3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
While experimenting on self-intersecting polyhedral surfaces, I met two bugs:
edge_min_sizewas not enough taken into account inProtect_edges_sizing_field,edge_distancewas missing the information of whichcurve_idthe edge belongs to (available using internal code)causing crashes.
Release Management