Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building CICE with NEMO 3.6 #366

Closed
phil-blain opened this issue Sep 20, 2019 · 6 comments
Closed

Building CICE with NEMO 3.6 #366

phil-blain opened this issue Sep 20, 2019 · 6 comments
Assignees
@apcraig @phil-blain
Labels
Porting Priority: Extreme Software Engineering Testing

Comments

@phil-blain
Copy link
Member

phil-blain commented Sep 20, 2019 •
edited
Loading

I'm starting to work on coupling CICE6 with NEMO 3.6 for our ice-ocean forecasting systems at ECCC.

First step is getting it to compile; how it was done for CICE4 and CICE5 is that the NEMO build system (a deprecated version of FCM) is in charge of compiling a single executable comprising both NEMO and CICE code.
I noted a first issue here #363 (comment) which was solved with #365.
Another issue is I found out that the file ice_dyn_evp_1d.F90 contains 3 Fortran modules (dmi_omp, bench_v2 and ice_dyn_evp_1d), and this is not handled by FCM (it expects 1 module per file) so the compilation aborts.

I think the easiest and cleanest way to solve this would be to split this file into 3 (one per module), and maybe renaming them for consistency with the rest of the CICE code base (ice_*).
@apcraig @TillRasmussen what do you think ?
@apcraig
Copy link
Contributor

apcraig commented Sep 20, 2019

I am testing CICE in RASM right now too. I haven't updated the RASM CICE code for over 6 months. I believe I am seeing the same issue. I think splitting the files as proposed is a good idea.

I would like to create a PR for CICE that addresses this issue and any other issues I find in the RASM integration testing. I think this needs to be sorted out before the next CICE release. This is top priority for me right now and I hope to have a PR in a few days. @phil-blain, are you OK if I take this task on as high priority?

@TillRasmussen
Copy link
Contributor

I don't have a problem splitting each module into their own file.
-> @phil-blain Phil-blain May I ask why you work on Nemo 3.6 instead of 4?

@apcraig
Copy link
Contributor

apcraig commented Sep 20, 2019

@TillRasmussen how about combining all 3 modules under the single ice_dyn_evp_1d module. The only public interfaces in the file are in ice_dyn_evp_1d so the subroutines in dmi_omp and bench_v2 could just be private subroutines in ice_dyn_evp_1d.

@TillRasmussen
Copy link
Contributor

That would probably work fine

@phil-blain
Copy link
Member Author

@apcraig yes no problem, be my guest!
@TillRasmussen we just migrated our operational systems to NEMO 3.6 so we want to do things one step at a time... NEMO 4 is on the roadmap but further down the road.

@apcraig apcraig mentioned this issue Sep 23, 2019
Merged
16 tasks
@apcraig
Copy link
Contributor

apcraig commented Sep 30, 2019

This should be addressed in #367 and am closing.

@apcraig apcraig closed this as completed Sep 30, 2019
phil-blain added a commit to phil-blain/CICE that referenced this issue Jun 22, 2021
@phil-blain
icepack: optionally compute 'dragio' using under-ice roughness length
6a4be6d 
In CICE-Consortium/Icepack@a80472b (icepack_parameters: optionally
compute 'dragio' from under-ice roughness (CICE-Consortium#366), 2021-06-22), Icepack
was updated to optionally compute the ice-ocean drag coefficicent
'dragio' using an under-ice roughness length and the thickness of the
first ocean level.

Leverage this new feature in CICE by adding 'calc_dragio' and
'iceruf_ocn' to the CICE namelist. Add the new variables to the index in
the documentation and add a test with the new feature (using default
values for 'iceruf_ocn' and 'thickness_ocn_layer1').

As this new feature will mostly be useful in a coupled context, we do
not add 'thickness_ocn_layer1' to the namelist as it is expected that
the ocean model will pass this information to CICE.
@phil-blain phil-blain mentioned this issue Jun 23, 2021
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apcraig apcraig

@phil-blain phil-blain

Labels
Porting Priority: Extreme Software Engineering Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@apcraig @TillRasmussen @phil-blain