Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update codecov script and documentation #314

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Update codecov script and documentation #314

merged 1 commit into from
Apr 24, 2020

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Apr 21, 2020

PR checklist

  • Short (1 sentence) summary of your PR:
    Update codecov script to address token issue
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Tested new logic, basic test suite was run.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

@apcraig apcraig mentioned this pull request Apr 21, 2020
Merged
16 tasks
@apcraig apcraig merged commit fcc2657 into CICE-Consortium:master Apr 24, 2020
@apcraig apcraig mentioned this pull request May 4, 2020
Open
lettie-roach pushed a commit to lettie-roach/Icepack that referenced this pull request Oct 18, 2022
@apcraig @eclare108213
port to cori (CICE-Consortium#314)
280d5ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eclare108213 eclare108213 eclare108213 approved these changes

@rallard77 rallard77 rallard77 approved these changes

@phil-blain phil-blain phil-blain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apcraig @eclare108213 @rallard77 @phil-blain