Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIDC-1067 some perfecting tweaks #568

Merged
merged 1 commit into from
Sep 3, 2021
Merged

CIDC-1067 some perfecting tweaks #568

merged 1 commit into from
Sep 3, 2021

Conversation

scvannost
Copy link
Collaborator

What

Lots of small tweaks to perfect current implementation of relational db

Why

Extends CIDC-1067 to fix small bugs and differences with the original schemas.
Extra worksheet of Essential Participant Data on tissue slides.
Found a few bugs while writing some developer documentation.

Checklist

Please include and complete the following checklist. You can mark an item as complete with the - [x] prefix:

  • Tests - Added unit tests for new code, regression tests for bugs and updated the integration tests if required
  • Formatting & Linting - black and flake8 have been used to ensure styling guidelines are met
  • Type Annotations - All new code has been type annotated in the function signatures using type hints
  • Docstrings - Docstrings have been provided for functions
  • Documentation - README has been updated to explain major changes & new features
  • Package version - Manually bumped the API package version in setup.py

@scvannost scvannost requested review from roshni-b and jim-bo September 2, 2021 17:52
@scvannost scvannost merged commit 6386c41 into master Sep 3, 2021
@scvannost scvannost deleted the relational-tweaks branch September 3, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants