-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checks for identifiers #159
base: main
Are you sure you want to change the base?
Conversation
451f7b6
to
16dd93f
Compare
16dd93f
to
9182022
Compare
In preparation to add CheckIndentifiers, this mode needs to be removed.
9182022
to
06bf506
Compare
With some projects it crashes on loading: ASSERT: "m_isLocked" in file /usr/include/qt6/QtCore/qmutex.h, line 249
|
Does it also crash on the same projects with the |
No, it does not. But there are not many comments in the project that makes it crash. |
Looked into the code to find and I don't understand the logic there. Here is the simplified fragment: QMutexLocker locker( &d->futureMutex );
...
if (/*condition*/) { // (1)
...
locker.unlock(); // (2)
...
}
locker.unlock() // (3) Why is it manually unlocked at (3)? At (2)? And of course now it it obvious why is assert triggered when the condition at (1) is true. I'd remove both manual unlock() calls? |
Adds an option and test for identifier tokens.
Closes #56.