Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quotes to values containing spaces #198

Merged
merged 4 commits into from
Jan 19, 2019
Merged

Conversation

ncihnegn
Copy link
Contributor

@ncihnegn ncihnegn commented Jan 19, 2019

Because CLI11 will fail to parse an INI file with such values.
To fix #195.

@codecov
Copy link

codecov bot commented Jan 19, 2019

Codecov Report

Merging #198 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #198   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        1893   1900    +7     
=====================================
+ Hits         1893   1900    +7
Impacted Files Coverage Δ
include/CLI/StringTools.hpp 100% <100%> (ø) ⬆️
include/CLI/Config.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1933a21...b21eb5c. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 19, 2019

Codecov Report

Merging #198 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #198   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        1889   1898    +9     
=====================================
+ Hits         1889   1898    +9
Impacted Files Coverage Δ
include/CLI/StringTools.hpp 100% <100%> (ø) ⬆️
include/CLI/Config.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd67a95...e5957b6. Read the comment docs.

@henryiii henryiii merged commit 9cfa0f4 into CLIUtils:master Jan 19, 2019
@henryiii henryiii added this to the v1.7 milestone Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config_to_str() doesn't quote default values correctly
2 participants