Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Msvc warn fix #20

Merged
merged 5 commits into from
Jun 5, 2017
Merged

Msvc warn fix #20

merged 5 commits into from
Jun 5, 2017

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Jun 5, 2017

This provides specialized windows code for getenv, fixing the warning given with W4. Fixes #10.

@codecov
Copy link

codecov bot commented Jun 5, 2017

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #20   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines        1044   1048    +4     
  Branches      219    220    +1     
=====================================
+ Hits         1044   1048    +4
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c1a622...2bc77eb. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 5, 2017

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #20   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines        1044   1055   +11     
  Branches      219    221    +2     
=====================================
+ Hits         1044   1055   +11
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <100%> (ø) ⬆️
include/CLI/Validators.hpp 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c1a622...2bc77eb. Read the comment docs.

@henryiii henryiii merged commit 0da8fa9 into master Jun 5, 2017
@henryiii henryiii deleted the msvc_warn_fix branch June 5, 2017 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows warning
1 participant