Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some warnings generated from klocwork static analyzer #350

Merged
merged 3 commits into from
Nov 29, 2019

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Nov 26, 2019

We run Klocwork static analyzer occasionally on our code base of which CLI11 is a part. This PR fixes some issues that came up in the static analyzer.

@codecov
Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #350 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #350   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        3347   3346    -1     
=====================================
- Hits         3347   3346    -1
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <100%> (ø) ⬆️
include/CLI/TypeTools.hpp 100% <100%> (ø) ⬆️
include/CLI/Validators.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51a395e...43dc054. Read the comment docs.

@henryiii henryiii merged commit 5f69659 into CLIUtils:master Nov 29, 2019
@henryiii henryiii deleted the klockwork_warning_fixes branch November 29, 2019 13:54
@henryiii henryiii added this to the v1.9 milestone Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants