Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effective C++ #354

Merged
merged 2 commits into from
Nov 30, 2019
Merged

Effective C++ #354

merged 2 commits into from
Nov 30, 2019

Conversation

henryiii
Copy link
Collaborator

Closes #344.

Also updating the actions to use pre-commit's new action, as mentioned in pre-commit/action#1; this PR will initially fail the format check to make sure it's working!

@henryiii henryiii force-pushed the henryiii-effc branch 2 times, most recently from 70cf2db to 1b1b76b Compare November 29, 2019 15:08
@codecov
Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #354 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #354   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        3352   3352           
=====================================
  Hits         3352   3352
Impacted Files Coverage Δ
include/CLI/Validators.hpp 100% <ø> (ø) ⬆️
include/CLI/Option.hpp 100% <ø> (ø) ⬆️
include/CLI/App.hpp 100% <ø> (ø) ⬆️
include/CLI/FormatterFwd.hpp 100% <ø> (ø) ⬆️
include/CLI/ConfigFwd.hpp 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f69659...edaec9a. Read the comment docs.

@henryiii henryiii marked this pull request as ready for review November 30, 2019 02:48
@henryiii henryiii merged commit 67dc672 into master Nov 30, 2019
@henryiii henryiii deleted the henryiii-effc branch November 30, 2019 02:49
@henryiii henryiii added this to the v1.9 milestone Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: -Weffc++
1 participant