Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CUDA NVCC build #365

Merged
merged 3 commits into from
Dec 10, 2019
Merged

Adding CUDA NVCC build #365

merged 3 commits into from
Dec 10, 2019

Conversation

henryiii
Copy link
Collaborator

Added to highlight NVCC warnings. See #359.

@henryiii henryiii changed the title Adding CUDA build Adding CUDA NVCC build Dec 10, 2019
@henryiii
Copy link
Collaborator Author

Warnings look like this:

/cli11/include/CLI/TypeTools.hpp(143): warning: invalid narrowing conversion from "double" to "int"
          detected during:
            instantiation of "CLI::detail::is_direct_constructible<T, C>::test [with T=int, C=double]" based on template arguments <int, double>
(150): here
            instantiation of class "CLI::detail::is_direct_constructible<T, C> [with T=int, C=double]"
/cli11/include/CLI/Validators.hpp(380): here

/cli11/include/CLI/TypeTools.hpp(143): warning: invalid narrowing conversion from "int" to "double"
          detected during:
            instantiation of "CLI::detail::is_direct_constructible<T, C>::test [with T=double, C=int]" based on template arguments <double, int>
(150): here
            instantiation of class "CLI::detail::is_direct_constructible<T, C> [with T=double, C=int]"
/cli11/include/CLI/Validators.hpp(399): here

/cli11/include/CLI/TypeTools.hpp(143): warning: invalid narrowing conversion from "double" to "__nv_bool"
          detected during:
            instantiation of "CLI::detail::is_direct_constructible<T, C>::test [with T=__nv_bool, C=double]" based on template arguments <__nv_bool, double>
(150): here
            instantiation of class "CLI::detail::is_direct_constructible<T, C> [with T=__nv_bool, C=double]"
/cli11/include/CLI/App.hpp(758): here

@phlptp
Copy link
Collaborator

phlptp commented Dec 10, 2019

This looks pretty similar to the warning that was blocked on gcc.

@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #365 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #365   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        3397   3397           
=====================================
  Hits         3397   3397
Impacted Files Coverage Δ
include/CLI/TypeTools.hpp 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9379cc...6244055. Read the comment docs.

@henryiii
Copy link
Collaborator Author

Warning and one build error fixed on NVCC, NVCC is now part of the testing.

@henryiii henryiii merged commit 3bdbbd7 into master Dec 10, 2019
@henryiii henryiii deleted the henryiii-cuda branch December 10, 2019 16:42
@henryiii henryiii added this to the v1.9 milestone Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants