Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlimited optionals without space bugfix #91

Merged
merged 1 commit into from
Mar 25, 2018
Merged

Unlimited optionals without space bugfix #91

merged 1 commit into from
Mar 25, 2018

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Mar 25, 2018

Fixes an error in the logic when mixing unlimited options and positionals when the option is given in short form with no space. Fixes #90.

@codecov
Copy link

codecov bot commented Mar 25, 2018

Codecov Report

Merging #91 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #91   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines        1396   1398    +2     
=====================================
+ Hits         1396   1398    +2
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ef176e...0d943f0. Read the comment docs.

@henryiii henryiii changed the title Adding test and fix for #90 Unlimited optionals without space bugfix Mar 25, 2018
@henryiii henryiii merged commit aa7c01f into master Mar 25, 2018
@henryiii henryiii deleted the fix90 branch March 25, 2018 15:56
@henryiii henryiii added this to the v1.5 milestone Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant