Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOREF] Upgraded React -> v18 && Trussworks -> v6 && Node -> v20.12.2 #2968

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

patrickseguraoddball
Copy link
Contributor

@patrickseguraoddball patrickseguraoddball commented Jan 28, 2025

NOREF

Description

  • Upgraded react & react-dom -> ^18.3.1
    • NOTE: Typescript currently has issues with @types/react & @types/react-dom and needs a resolution to @types/react@17.*
    • https://zackery.dev/posts/types-react/#fromHistory
    • This resolution was technically added in the previous dependabot PR, but holding off on upgrading @types/react to ^18.3.1 until resolved
  • Upgraded @trussworks/react-uswds -> ^6.0.0
    • Replaced instances of Dropdown with Select
  • Upgraded Node -> v20.12.2

React v19 is technically out, but included more breaking changes

How to test this change

  • Tests pass and functionally works as always

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

Copy link

EKS Ingress URLs

@patrickseguraoddball patrickseguraoddball marked this pull request as ready for review January 28, 2025 17:32
@patrickseguraoddball patrickseguraoddball marked this pull request as draft January 28, 2025 17:41
@patrickseguraoddball patrickseguraoddball changed the title [NOREF] Upgraded React -> v18 && Trussworks -> v6 [NOREF] Upgraded React -> v18 && Trussworks -> v6 && Node -> v20.12.2 Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant