Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EASI-4683] Update About the Portfolio Update Report modal text #2975

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

garyjzhao
Copy link
Collaborator

EASI-4683

Description

  • Updated copy to match what is written in the ticket

How to test this change

  1. Click the "What's included in the Portfolio Update Report?" on the ITGO Admin home page
  2. Verify that the text in the "About the Portfolio Update Report" modal matches

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@garyjzhao garyjzhao requested a review from a team as a code owner January 29, 2025 19:03
@garyjzhao garyjzhao requested review from aterstriep and removed request for a team January 29, 2025 19:03
Copy link

EKS Ingress URLs

Copy link
Contributor

@patrickseguraoddball patrickseguraoddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG thanks

@garyjzhao garyjzhao merged commit 7588907 into main Jan 29, 2025
14 checks passed
@garyjzhao garyjzhao deleted the EASI-4683/updatemodaltext branch January 29, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants