Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EASI-4429] Persist TRB Table Configuration #2982

Merged
merged 10 commits into from
Feb 5, 2025

Conversation

garyjzhao
Copy link
Collaborator

@garyjzhao garyjzhao commented Feb 4, 2025

EASI-4429

Description

  • Add trbExistingRequests to TableStateWrapper context
  • pulled in the new trbExistingRequests state from context to TrbAdminTeamHome
  • add initialFilter prop in the GlobalClientFilter used in TrbAdminTeamHome

How to test this change

  • Login as Admin and view the TRB table
  • Play around to ensure page size, query, sort persists

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@garyjzhao garyjzhao marked this pull request as ready for review February 4, 2025 20:33
@garyjzhao garyjzhao requested a review from a team as a code owner February 4, 2025 20:33
@garyjzhao garyjzhao requested review from adamodd and patrickseguraoddball and removed request for a team and adamodd February 4, 2025 20:33
Copy link

github-actions bot commented Feb 4, 2025

EKS Ingress URLs

@aterstriep aterstriep self-assigned this Feb 5, 2025
@aterstriep aterstriep self-requested a review February 5, 2025 16:05
Copy link
Contributor

@patrickseguraoddball patrickseguraoddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except for pagination persistence. I realize that it wasn't working on the existing ITGov table, but if you could take a look to get pagination to persist, that would be appreciated, thanks. It looks as though the state.pageIndex is not being set properly. If you want to sync, I'd be happy to help dig through the culprit more closely

Copy link
Contributor

@patrickseguraoddball patrickseguraoddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG thanks

@garyjzhao garyjzhao merged commit 361cf5f into main Feb 5, 2025
15 checks passed
@garyjzhao garyjzhao deleted the EASI-4429/persist-table-configuration branch February 5, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants