Skip to content

Commit

Permalink
Merge branch 'master' into WNMGDS-281/move-hint-error-outside-legend
Browse files Browse the repository at this point in the history
  • Loading branch information
bernardwang authored Nov 4, 2019
2 parents fb7300f + 680304e commit 4496062
Show file tree
Hide file tree
Showing 9 changed files with 6 additions and 185 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ Style guide: components.autocomplete.react
### When to use
- If you are returning results from a known domain like a database of zip codes or a taxonomy of keywords
- If you have a list of options that would cause a [select menu](/components/select) to be unusually long
- If you have a list of options that would cause a [dropdown](/components/dropdown) to be unusually long
### When to consider alternatives
- When users are choosing from a specific set of options. Consider [checkboxes, radio buttons](/components/choice), or a [select menu](/components/select) in these cases.
- When users are choosing from a specific set of options. Consider [checkboxes, radio buttons](/components/choice), or a [dropdown](/components/dropdown) in these cases.
### Usage
Expand Down
20 changes: 0 additions & 20 deletions packages/core/src/components/ChoiceList/Select.e2e.test.js

This file was deleted.

43 changes: 0 additions & 43 deletions packages/core/src/components/ChoiceList/Select.example.jsx

This file was deleted.

14 changes: 2 additions & 12 deletions packages/core/src/components/ChoiceList/_ChoiceList.docs.scss
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,6 @@ Markup: checkbox-radio.example.html
Style guide: components.choice
*/

/*
Right-to-Left
<span class="ds-c-badge ds-u-margin-right--1 ds-u-text-transform--capitalize">Deprecated</span>
Markup: checkbox-radio-right-to-left.example.html
Style guide: components.choice.rtl
*/

/*
`<ChoiceList>`
Expand Down Expand Up @@ -62,7 +52,7 @@ Style guide: components.choice.react
### When to consider alternatives
- If there are too many options to display on a mobile screen. Consider a `select` menu if you don’t have enough space to list out all available options, and if the user can only select one of the options.
- If there are too many options to display on a mobile screen. Consider a `dropdown` menu if you don’t have enough space to list out all available options, and if the user can only select one of the options.
- Never use radio buttons for optional questions, since once a radio button is selected from a list, it or another choice will remain selected.
### Usage
Expand Down Expand Up @@ -108,7 +98,7 @@ The following Sass variables can be overridden to theme choice fields:
### Related patterns
- [Select menu](/components/select)
- [Dropdown](/components/dropdown)
### Learn more
Expand Down
78 changes: 0 additions & 78 deletions packages/core/src/components/ChoiceList/_Select.docs.scss

This file was deleted.

27 changes: 0 additions & 27 deletions packages/core/src/components/ChoiceList/select.example.html

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Style guide: components.text-field.react
### When to consider alternatives
- When users are choosing from a specific set of options. Consider [checkboxes, radio buttons](/components/choice), or a [select menu](/components/select) in these cases.
- When users are choosing from a specific set of options. Consider [checkboxes, radio buttons](/components/choice), or a [dropdown](/components/dropdown) in these cases.
### Usage
Expand Down
1 change: 0 additions & 1 deletion packages/core/src/components/_index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
@import 'Badge/Badge';
@import 'Button/Button';
@import 'ChoiceList/Choice'; // This should eventually be renamed to `ChoiceList`
@import 'ChoiceList/Select';
@import 'Dialog/Dialog';
@import 'Dropdown/Dropdown';
@import 'FormLabel/FormLabel';
Expand Down
2 changes: 1 addition & 1 deletion packages/docs/src/pages/guidelines/forms.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
title: Forms
---

The design system includes components for the standard HTML form elements: [checkboxes and radio buttons]({{root}}/components/choice), [text fields]({{root}}/components/text-field), [select menus]({{root}}/components/select), fieldsets, labels, and so on.
The design system includes components for the standard HTML form elements: [checkboxes and radio buttons]({{root}}/components/choice), [text fields]({{root}}/components/text-field), [dropdowns ]({{root}}/components/dropdown), fieldsets, labels, and so on.

Below are some best practices your project should aim to follow in order to provide the most accessible and usable experience for your users. Additional guidance, specific to each form field, is provided in each component's guidance tab.

Expand Down

0 comments on commit 4496062

Please sign in to comment.