Fix sonarqube not scanning dpc-portal #2104
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/DPC-3971
🛠 Changes
Reverted simplecov gem to 0.17
ℹ️ Context for reviewers
Sonarqube stopped processing portal code coverage on Mar 5; the day the rails upgrade was merged into master. As part of the upgrade simplecov was not pinned to 0.17. Simplecov 0.18+ breaking ci is a known issue.
There was comment (present in the other gemfiles) warning not to upgrade, but it was removed because for some reason, when I run
bundle install
after sshing into the docker container, it will fail if there are too many bytes in the Gemfile. I removed "extraneous" comments, which meant I missed this.✅ Acceptance Validation
Ran the build and checked the coverage.
🔒 Security Implications
If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.