Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QPPSE-1289: Automate PCF APM entity file updating #1384

Merged
merged 11 commits into from
Dec 13, 2023
Merged

QPPSE-1289: Automate PCF APM entity file updating #1384

merged 11 commits into from
Dec 13, 2023

Conversation

sivaksb
Copy link
Contributor

@sivaksb sivaksb commented Nov 22, 2023

Information

  • Due to Codebuild not able to communicate with QPP Auth resources (VPN issues), implementing manual local run of the file updation. Once the codebuild is capable of communicating with QPP Auth or FMS, the automation will be implemented. All other setup is verified.
  • When the automation is implemented, it will use the secrets provided to the Scoring Engine team. The secrets are verified as working and all the necessary folder access is granted already.

Checklist

  • All JUnit tests pass (mvn clean verify).
  • New unit tests written to cover new functionality.
  • Added and updated JavaDocs for non-test classes and methods.
  • No local design debt. Do you feel that something is "ugly" after your changes?
  • Updated documentation (README.md, etc.) depending if the changes require it.

@sivaksb sivaksb requested a review from saquino0827 as a code owner November 22, 2023 15:50
Jpec07
Jpec07 previously approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@Jpec07 Jpec07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good based on my experience with FMS.

gerickson808
gerickson808 previously approved these changes Nov 28, 2023
View reviewed changes
@sivaksb sivaksb dismissed stale reviews from Jpec07 and gerickson808 via bc2c3fa December 12, 2023 19:58
@sivaksb sivaksb requested a review from Jpec07 December 12, 2023 19:58
Jpec07
Jpec07 previously approved these changes Dec 12, 2023
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sivaksb sivaksb merged commit 2a90034 into develop Dec 13, 2023
3 checks passed
@sivaksb sivaksb deleted the feature/QPPSE-1289_Automate_PCF_APM_Entity_File_Updation branch December 13, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saquino0827 saquino0827 saquino0827 approved these changes

@Jpec07 Jpec07 Awaiting requested review from Jpec07 Jpec07 is a code owner

@gerickson808 gerickson808 Awaiting requested review from gerickson808

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sivaksb @gerickson808 @saquino0827 @Jpec07