Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark deprecated aliases that belong to deprecated data items #480

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

vaitkus
Copy link
Collaborator

@vaitkus vaitkus commented Feb 20, 2024

This PR supplements PR #479.

I accidentally left out several deprecated aliases since they belong to data items that have also been deprecated in DDLm (see _definition_replaced.by attribute). I think it is still make sense to assign the specific deprecation date to data names inherited from DDL1.

@vaitkus vaitkus requested a review from jamesrhester February 20, 2024 09:55
@vaitkus vaitkus linked an issue Feb 20, 2024 that may be closed by this pull request
@jamesrhester jamesrhester merged commit 8e4be12 into COMCIFS:master Feb 21, 2024
3 checks passed
@vaitkus vaitkus deleted the mark-more-deprecated-aliases branch February 22, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should data names deprecated in DDL1 be deprecated in DDLm?
2 participants