-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completed all tasks #1
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A neat and clean implementation with nice additions to the UI.
Great use of toast alerts at every step.
Adding the Search feature was wise, but implementation and working can to be improved:
- On searching empty text, all tasks should be visible (or clear filter button)
- On deletion of a task after filtering, the DOM is not getting updated.
- Feature Improvement : could have also looked into returning the results in real-time. ( Current Implementation is also great! )
}) | ||
.then(() => { | ||
this.$toast.success('Todo deleted successfully!') | ||
this.todos.splice(_index, 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good use of splice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filtered Todos not updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized this. Any idea why is this happening?
I am updating this.todos
as using the splice
method, and the filteredTodos
is itself a computed property defined on this.todos
, so shouldn't it be updating automatically?
Repo
Deployment
Tasks
Additional