Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Developer guide for converting notebooks to rst; #135

Merged
merged 7 commits into from
May 10, 2018
Merged

Conversation

drewejohnson
Copy link
Collaborator

Closes #125

Add content largely to docs/develop in response to #123 where the plain conversion jupyter nbconvert --to=rst requires minor intervention. The developer also has to

  1. Remove the ipython3 segments from the code blocks
  2. Move images into docs/ directory
  3. Update image links accordingly

Add information on writing a good commit message using information from git book

andrewjohnson added 7 commits May 9, 2018 15:45
Included gotchas such as code not rendering due to
bad ipython3 lexer and images not showing due to
bad paths.

Also included details on adding new classes/functions
via the API section.
Added `docs/develop/plot.rst` to give some instruction
on how we provide a cohesive plotting environment.
Options for the `magicPlotDocDecorator` are included
via `docs/magicPlotDoc.py` that give all the magic strings
we look for when applying magicPlotDoc.
This helps git know not to attempt EOL conversions
Took some content from the git handbook to describe how to write
a good git commit. These are helpful for our project, but also
great practice for future projects.
@drewejohnson drewejohnson added this to the 0.4.0 milestone May 10, 2018
@drewejohnson drewejohnson requested a review from DanKotlyar May 10, 2018 13:55
@drewejohnson drewejohnson merged commit 06c27b7 into develop May 10, 2018
@drewejohnson drewejohnson deleted the fix125 branch May 10, 2018 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants