Add python pkg structure + add automated CI testing pipeline + add Coverage report #26
Conversation
|
#12 should be addressed here -- at least the CI pipeline should be created :) |
|
@angus-g is this error |
|
@ashjbarnes mentioned that some of the dependencies need to be installed via conda. Would something like this |
|
https://github.com/COSIMA/mom6-regional/actions/runs/5196044606/jobs/9369359484#step:4:314 are you sure the package is called |
|
OK, I think I made the CI reach the point where it actually wants to run the tests... but the |
|
OK, the test pipeline works! @angus-g did I do it correctly? Any ideas, suggestions are welcome! |
It was called that when I made that commit -- it was at a time when they transitioned it into the pangeo organisation, but didn't have control of the xesmf name on PyPI. I guess now they've moved back to just plain old xesmf so that's fine.
I'll have a look today. |
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
========================================
Coverage ? 8.66%
========================================
Files ? 2
Lines ? 450
Branches ? 0
========================================
Hits ? 39
Misses ? 411
Partials ? 0 |
|
OK, I added code coverage report also! |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
OK, this is ready! |
| @@ -18,15 +18,14 @@ | |||
| "import subprocess\n", | |||
There was a problem hiding this comment.
navidcy
changed the title
|
Eek. I'm going to force-push a reversion, I don't want to merge yet. |
|
Oops sorry!
…On Wed, 14 Jun 2023 at 11:59, Angus Gibson ***@***.***> wrote:
Eek. I'm going to force-push a reversion, I don't want to merge yet.
—
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMWQL4A7KOB2ATDBVHJEL2TXLELIVANCNFSM6AAAAAAYX5EK2Y>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
No problem, I just haven't looked at any of the new stuff yet! |
|
@angus-g do that! also @ashjbarnes it’s good practice to leave the person who open the review to merge. |
|
Yes that makes sense! Will do in future
…On Wed, 14 Jun 2023 at 12:02, Navid C. Constantinou < ***@***.***> wrote:
@angus-g <https://github.com/angus-g> do that!
also @ashjbarnes <https://github.com/ashjbarnes> it’s good practice to
leave the person who open the review to merge.
—
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMWQL4GXJH7WQFMSTPKOYW3XLELR7ANCNFSM6AAAAAAYX5EK2Y>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Don’t worry! No harm! |
This PR converts the repo towards a python package! Also, the PR adds a testing CI pipeline and a Coverage report via Codecov.io. This is the first step towards #12, but it doesn't resolve it since the test include here are just placeholder (e.g., they are trivialities, like test whether
4**2 == 16).