Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename repo/package mom6_regional -> regional_mom6 #47

Merged
merged 12 commits into from
Jun 22, 2023
Merged

Conversation

navidcy
Copy link
Contributor

@navidcy navidcy commented Jun 22, 2023

Last time. :)

@navidcy navidcy requested review from angus-g and ashjbarnes June 22, 2023 04:51
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@angus-g angus-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be fine assuming all the automation still works!

demos/model-forced.ipynb Outdated Show resolved Hide resolved
demos/reanalysis-forced.ipynb Outdated Show resolved Hide resolved
@navidcy
Copy link
Contributor Author

navidcy commented Jun 22, 2023

the notebook will need an update to replace all ml. to rm.... I'll go through them now :)

README.md Outdated Show resolved Hide resolved
@navidcy
Copy link
Contributor Author

navidcy commented Jun 22, 2023

there is a chance I broke the docs?

@angus-g
Copy link
Collaborator

angus-g commented Jun 22, 2023

It should be coming back online, I had to fiddle some stuff because of the name change.

Co-authored-by: Angus Gibson <[email protected]>
@navidcy
Copy link
Contributor Author

navidcy commented Jun 22, 2023

Where do you fiddle?

@angus-g
Copy link
Collaborator

angus-g commented Jun 22, 2023

It's set up on readthedocs.org, I think it should all be working now though.

@navidcy navidcy requested a review from angus-g June 22, 2023 05:10
@navidcy
Copy link
Contributor Author

navidcy commented Jun 22, 2023

The codecov is OK with the name change ;)

@navidcy
Copy link
Contributor Author

navidcy commented Jun 22, 2023

I think this is good to go.

@angus-g
Copy link
Collaborator

angus-g commented Jun 22, 2023

Nearly! Formatting failure, then hopefully tests pass.

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #47 (2960fe7) into main (4f76be5) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #47   +/-   ##
=======================================
  Coverage   10.72%   10.72%           
=======================================
  Files           2        2           
  Lines         429      429           
=======================================
  Hits           46       46           
  Misses        383      383           
Impacted Files Coverage Δ
regional_mom6/regional_mom6.py 10.14% <ø> (ø)
regional_mom6/__init__.py 60.00% <100.00%> (ø)

Copy link
Collaborator

@angus-g angus-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems all good now!

@navidcy
Copy link
Contributor Author

navidcy commented Jun 22, 2023

All goof :)

@navidcy navidcy merged commit 2da3e29 into main Jun 22, 2023
@navidcy navidcy deleted the ncc/rename-repo branch June 22, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants