Bugfix: Bathymetry regridding and B grid velocity regridding.

[ashjbarnes]

at this step the intermediate 'topog_raw.nc' file already has vertical coordinate named elevation. Threw an error when vcoord had different name

[navidcy]

Test fail. Probably the black?
Also, could we change the PR name into something more descriptive?
Otherwise I'm happy to approve as soon as I see tests pass.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6b5817e) 72.97% compared to head (39bb631) 72.97%.

❗ Current head 39bb631 differs from pull request most recent head e26cd81. Consider uploading reports for the commit e26cd81 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   72.97%   72.97%           
=======================================
  Files           3        3           
  Lines         444      444           
=======================================
  Hits          324      324           
  Misses        120      120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[navidcy]

lgtm, let's just rename the PR to something more descriptive.

[navidcy]

oh wait, I got confused.... you merged a different PR on this branch?
I think the black formatting is still an issue

[ashjbarnes]

Oops sorry Navid you were so speedy! I failed to see that you'd already approved changes

I made another PR to fix an issue with the regridder (Luwei found the bug) and figured they could go together but maybe that was a mistake

[navidcy]

Can we enhance the tests so they catch these things or you think it's not worth it?

[ashjbarnes]

Yes tests definitely need enhancing to include more edge cases. They're pretty basic for now and even that has been very helpful.

[navidcy]

Oops sorry Navid you were so speedy! I failed to see that you'd already approved changes

I made another PR to fix an issue with the regridder (Luwei found the bug) and figured they could go together but maybe that was a mistake

All good! :)

thanks @luweiyang

[navidcy]

Yes tests definitely need enhancing to include more edge cases. They're pretty basic for now and even that has been very helpful.

Well, I was suggesting we enhanced in this PR :)
Perhaps raise an issue to list the things we can improve them.