Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macro code to use boolean value in while instruction (false) #469

Merged
merged 2 commits into from
May 8, 2023
Merged

Fix macro code to use boolean value in while instruction (false) #469

merged 2 commits into from
May 8, 2023

Conversation

michael-methner
Copy link
Collaborator

Fix macro code to use boolean value in while instruction (false)
Fixes #308

Signed-off-by: Michael Methner [email protected]

@lvklevankhanh
Copy link
Contributor

Hi @michael-methner,
Should we change the "while(0)" at following lines?
https://github.com/COVESA/dlt-daemon/blob/master/include/dlt/dlt_cpp_extension.hpp#:~:text=%7D%5C-,while(0),-/**
https://github.com/COVESA/dlt-daemon/blob/master/include/dlt/dlt_cpp_extension.hpp#:~:text=%7D%5C-,while(0),-%23endif%20/*

@michael-methner michael-methner merged commit cfc2c86 into master May 8, 2023
@minminlittleshrimp minminlittleshrimp deleted the fix_macro_while_instructions branch October 19, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvklevankhanh lvklevankhanh lvklevankhanh approved these changes

@sucharitasamanta sucharitasamanta sucharitasamanta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coverity error with every DLT_LOG()
3 participants
@michael-methner @lvklevankhanh @sucharitasamanta