Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

several conditions are never reached in feature_function_activation #272

Closed
sildater opened this issue Jun 15, 2023 · 0 comments · Fixed by #274
Closed

several conditions are never reached in feature_function_activation #272

sildater opened this issue Jun 15, 2023 · 0 comments · Fixed by #274
Assignees
Labels
bug Something isn't working

Comments

@sildater
Copy link
Member

feature_function_activation in note_features.py requires some reworking. the function starts with

if isinstance(
        direction, (score.DynamicLoudnessDirection, score.DynamicTempoDirection)
    )

and within this conditional block continues to check for instances of score.ArticulationDirection which isn't a subclass of those.
Minor styling: line 787 should also check a class.
There are open todos, likely related to issue #244

@sildater sildater added the bug Something isn't working label Jun 15, 2023
@sildater sildater self-assigned this Jun 15, 2023
@manoskary manoskary linked a pull request Jun 15, 2023 that will close this issue
@sildater sildater mentioned this issue Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant